`proto3` doesn't pack repeated fields by default about prost HOT 5 OPEN

Just realised this is only the case where the field has other attributes and hence options is not None

from prost.

I don't understand what your request is. Can you describe your observed behavior and your expected behavior? An example file or project will help with reproducing your problem.

from prost.

We're hitting the same bug. Consider a field like this:

  repeated uint64 user_ids = 2 [
    (buf.validate.field).repeated.min_items = 1,
    (buf.validate.field).repeated.max_items = 25
  ];

This generates the following from prost:

#[prost(uint64, repeated, packed="false", tag="2")]
pub user_ids: ::prost::alloc::vec::Vec<u64>,

However if I remove the options, like this:

  repeated uint64 user_ids = 2;

Then the generated code looks like this:

#[prost(uint64, repeated, tag="2")]
pub user_ids: ::prost::alloc::vec::Vec<u64>,

As @daniel-sherwood correctly identified, this is a bug at

In my first example, there are options on the field so map_or does not use its default and the code falls back to options.packed(). options.packed() appears to be either true or false, with a default of false. But it should default to true if the file is in proto3 syntax.

from prost.

Thanks, now I understand your problem better. Are you willing to open a PR to fix this?

from prost.

Maybe! It'd be my first time trying Rust, so it'd probably take a while.

from prost.