Copy and paste inline should not create a new line about blocksuite HOT 8 OPEN

@doodlewind @zuoxiaodong0815 Thank you guys. I have found other more issues about clipboard and I'm trying to debug the code to solve them. I'm not sure whether it will be done, but later I'll submit the other issues.

from blocksuite.

I'm trying to solve this issue, and I think should remove handleBlockSplit code here.
Can someone please tell me why there need split block? Thanks a lot.

from blocksuite.

I'm trying to solve this issue, and I think should remove handleBlockSplit code here.
Can someone please tell me why there need split block? Thanks a lot.

cc @fourdim @zuoxiaodong0815

from blocksuite.

I'm trying to solve this issue, and I think should remove handleBlockSplit code here. Can someone please tell me why there need split block? Thanks a lot.

blocksuite/packages/blocks/src/__internal__/service/json2block.ts

Lines 51 to 57 in 52ecfd8

	shouldSplitBlock &&
	(await handleBlockSplit(
	page,
	focusedBlockModel,
	textRangePoint.index,
	0
	));

When the cursor is positioned in the middle of a block, the block needs to be split when pasting

from blocksuite.

This is the split block case.

from blocksuite.

I'm trying to solve this issue, and I think should remove handleBlockSplit code here. Can someone please tell me why there need split block? Thanks a lot.

blocksuite/packages/blocks/src/__internal__/service/json2block.ts

Lines 51 to 57 in 52ecfd8

	shouldSplitBlock &&
	(await handleBlockSplit(
	page,
	focusedBlockModel,
	textRangePoint.index,
	0
	));

When the cursor is positioned in the middle of a block, the block needs to be split when pasting

Thank you for clarifying, it's much clearer for me. Maybe more product design clarification is needed here.

from blocksuite.

@zuoxiaodong0815 I don't think we should add \n in the case you provided. A part of text can just be inserted unless it's copied with \n at the end together. @BangKk please feel free to modify the behavior here.

from blocksuite.

Yes, you are right @doodlewind . The issue is needed to be fixed. I just show why to split a block when focus in the middle of the block.
The right behave when not selected whole blocks is that the selected content should be removed, and after split to tow parts, the first pasted block join in the end of the first part, the last pasted block join in the begin of the last part. This issue is about the case of the behavior.

The right behave when selected whole blocks is that the selected content does not be removed, the focus block does not be split yet, the pasted content should pasted at the behind of selected blocks.

from blocksuite.