Inline mode not supported by NetBSD's sed about todo.txt-cli HOT 7 OPEN

Hello @exitnode !
We use the same workaround for the time/todotxt pkgsrc package (and the following sed(1) incantation does the trick!: sed -E -e 's,([(| ])sed ,\1gsed ,g)

What about introducing a ${SED} variable and replace all sed invocations with that?

(If that sounds reasonable please let me know and I'll try to write a possible patch about that!)

Thank you!

from todo.txt-cli.

What about introducing a ${SED} variable

You don't need that.

let the user define which sed version to use, e.g. in .todo/config

You can define a sed function in the config file and export it; todo.sh and any add-ons launched by it will then use that one:

export originalSed=$(which sed)
sed()
{
    # Assumption: The in-place option is passed as the first argument.
    if [ "$1" = '-i.bak' ]; then
        shift

        # Assumption: Only a single file is processed, and it is passed as the
        # last argument.
        file=${!#}

        tmpFile=/tmp/todo.sh-sed.$$
        "$originalSed" "$@" > "$tmpFile" && mv "$tmpFile" "$file"
    else
        "$originalSed" "$@"
    fi
}
export -f sed

This one emulates the sed -i without requiring gsed. If you have the latter, the override becomes even simpler:

sed()
{
    # Use gsed because it understands the -i in-place option.
    gsed "$@"
}
export -f sed

from todo.txt-cli.

@inkarkat should we include this in the documentation somewhere?

from todo.txt-cli.

from todo.txt-cli.

@karbassi I think this is only the first or maybe second time this came up. BSD isn't a terribly common platform, and most users are quite knowledgeable (and quite used to dealing with these compatibility issues). I'd wait until we see another such question, and now this should be more discoverable through this issue.

@iamleot Are you really using BSD as your sole platform and intend to do todo.sh dev work? I once used FreeBSD to verify the compatibility with Mac OS (don't have any Apple hardware, and Gina always tested on Mac) - fortunately, Mac OS has suitable sed and awk versions. The (huge) downside of @SED@ is that one is forced to run make; the script won't work without it any longer. Second: If you automate this, do you assume gsed is available, or even implement both gsed and the other workaround?! To me, this adds a lot of complexity without much benefit.

from todo.txt-cli.

from todo.txt-cli.

I created a linked PR that solves this, but it does not export the function for use by add-ons. This is because the new sed function's carries assumptions that may not remain true in all add-on code. Therefore, the scope of this fix includes code within this file's todo.sh only, which is probably good enough anyways.

from todo.txt-cli.