Code Monkey home page Code Monkey logo

Comments (3)

Niederb avatar Niederb commented on June 8, 2024 1

Thanks for the quick response. I implemented the changes to make the registers configurable in #3722.
I hope this is what you had in mind.

from tock.

lschuermann avatar lschuermann commented on June 8, 2024

Indeed your proposed approach would work. Most peripheral drivers in Tock take a reference to their respective register file (StaticRef), which would all multiple instantiations of the same driver over different hardware instances. This does not seem to be the case for the nRF52 UART driver right now, but we should definitely be open to changing that. Here's an example of what that may look like:

impl<'a> Uart16550<'a> {
pub fn new(regs: StaticRef<Uart16550Registers>) -> Uart16550<'a> {
// Disable all interrupts when constructing the UART
regs.ier.set(0xF);

Note that the DefaultPeripherals infrastructure has been explicitly designed such that you can instantiate a custom set of peripherals in your own board definition. Once the UART peripheral has been modified to take a register reference in its constructor, you can instantiate your own such peripheral set in a custom board module, by defining a custom peripherals struct similar to the Nrf52840DefaultPeripherals. The upstream Nrf52840DefaultPeripherals is supposed to cover most commonly used peripherals, and peripherals exposed on development boards. Thus we may not want to instantiate multiple UARTs in that particular peripheral set.

from tock.

Niederb avatar Niederb commented on June 8, 2024

Since #3722 has been merged I close this issue.

from tock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.