Code Monkey home page Code Monkey logo

Comments (7)

franzliedke avatar franzliedke commented on August 31, 2024 1

For PHP 7.0 compatibility, we would probably need a clearData() function then.

from json-api-php.

antonkomarev avatar antonkomarev commented on August 31, 2024

This will require to change signature to public function setData(?ElementInterface $element) what will lead drop PHP7.0 support. Because nullable types are available since PHP7.1 only.

from json-api-php.

rgazelot avatar rgazelot commented on August 31, 2024

What about public function setData(ElementInterface $element = null)?

from json-api-php.

antonkomarev avatar antonkomarev commented on August 31, 2024

By this way you will only be able to do $document->setData(); but not $docuemnt->setData(null). Try it yourself.

from json-api-php.

rgazelot avatar rgazelot commented on August 31, 2024

I agree that PHP7.1 nullable argument are by far the best way to do it, but I'm ok with the PHP7.0 compatibility. Maybe just keep in mind this thing for a future PHP7.1 support?

from json-api-php.

f3ath avatar f3ath commented on August 31, 2024

What about creating a special case: function setNullData(): void?

from json-api-php.

antonkomarev avatar antonkomarev commented on August 31, 2024

Before implement any of proposed ways we need to define concrete use case for it.

from json-api-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.