Code Monkey home page Code Monkey logo

Comments (5)

tnicola avatar tnicola commented on July 26, 2024

Hi @tb9-Mason ,
When you say that sometimes the step would show and sometimes not, you are navigating your app in a different order for the two cases, right? Is it your step on the root route?

Lets suppose you have 2 routes: routeA and routeB:
What you're saying is that its behaviour is chameleonic, sometimes it is initalized with routeA and sometimes with routeB, depending on which page is loaded first, is it right?

I'll have a look on this. Anyway, maybe the cleanest solution could be use the stepName as ID, without the route; in this way the stepName should be unique across all the app routes.

from ngx-joyride.

tb9-Mason avatar tb9-Mason commented on July 26, 2024

@tnicola Thanks for your quick reply
I am not navigating in a different order, but sometimes I was refreshing the app on the route that generated the correct ID and sometimes I was not.

In my case, the main app template where my step is located is always in a sub route of the application. You are correct in that sometimes the step ID is created as myStep@routeA and sometimes as myStep@routeB, but in the steps passed to startTour the name is always myStep@routeA.

from ngx-joyride.

tnicola avatar tnicola commented on July 26, 2024

Alright then, I'll try to reproduce it and i will fix it in the next days!

from ngx-joyride.

tnicola avatar tnicola commented on July 26, 2024

Hi @tb9-Mason ,
This issue should be fixed in the latest version 2.0.2. I removed the name + route check, now the lookup is only on the name. Let me know if it works.

from ngx-joyride.

tnicola avatar tnicola commented on July 26, 2024

Closing the issue.

from ngx-joyride.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.