Code Monkey home page Code Monkey logo

Comments (7)

Airblader avatar Airblader commented on September 23, 2024

I definitely wouldn't mind this. Are you interested in submitting a PR? I probably won't have time to do this myself, but happy to support.

from ngqp.

pumano avatar pumano commented on September 23, 2024

@Airblader ok, I will prepare PR soon, but can't test it before release, I just check for build properly, and after you release, I can test it

from ngqp.

pumano avatar pumano commented on September 23, 2024

@Airblader I stuck in your demo app, while trying to update project to 14 angular due to using raw-loader.

Webpack 5 don't have that loader, and have own 'asset/source' type for that. Currently it possible only via custom webpack config. Details: angular/angular-cli#21305

Can I only prepare PR with library change without changing demo website?

from ngqp.

Airblader avatar Airblader commented on September 23, 2024

Yes, I'm aware of that issue, which is why I never updated the demo either. I'm OK with excluding the demo here, but we'll need some kind of verification that it does work.

from ngqp.

pumano avatar pumano commented on September 23, 2024

It's hard to get, due to demo project contains 'raw-loader' webpack plugin, but angular 14 use webpack 5 where raw-loader does not exist, and need to change strategy of loading .ts files as text.

from ngqp.

pumano avatar pumano commented on September 23, 2024

looks like angular 16 remove ngcc util and library does not work more.

This likely means that the library (@ngqp/core) which declares QueryParamModule is not compatible with Angular Ivy.
Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to
see if the library is expected to be compatible with Ivy.

from ngqp.

pumano avatar pumano commented on September 23, 2024

commit: 979f038

from ngqp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.