Pane layout not saved if one pane was maximized about tmux-resurrect HOT 10 CLOSED

Hi, thanks for reporting the issue and writing specific 'how to reproduce' steps.
How big of an issue is this for you? How often do you use zoomed windows?

I did some work on 'zoomed' windows in cedd129, but didn't invest additional effort because I use this feature only occasionally and when I do, it's just for a short period of time.

Also, arguably this is tmux bug because tmux select-layout tmux list-windows does not return good output for zoomed windows.

Edit: it's not select-layout but list-windows command that has an unusual output.

from tmux-resurrect.

It's the only thing that I found in my day to day use so far. And I use zoomed windows quite often to get a better overview on the code that I'm writing. So I just tend to forget sometimes to unzoom because I have several codes open in different tabs. It's not necessary to fix it with high priority but if you have a few spare minutes at some stage it might be nice.
I will log in to #tmux tomorrow on freenode and see if I can get them to fix the bug in tmux select-layout. I'll let you know about the progress.

from tmux-resurrect.

Ups wrong button :)

I suppose the problem is with list-windows. I have filed a ticket on tmux's sourceforge page:
https://sourceforge.net/p/tmux/tickets/159/

from tmux-resurrect.

Okay great.
Yes, you are right, it's the tmux list-windows command that outputs unusual layout information for maximizes/zoomed windows.

from tmux-resurrect.

Hi bruno. Check the ticket on sourceforge again. Somebody suggested to unzoom before saving and then rezooming afterwards. Might be a fix for now if it is not too difficult to implement. Although I would be of the opinion that this requires a fix upstream.

from tmux-resurrect.

Hey, yes, that could be a workaround solution.
The implementation wouldn't be trivial but it's definitely doable.
It would be great if someone wants to get their hands dirty on this and open a pull request.

from tmux-resurrect.

Hands are dirty already. Saving and unzooming was pretty easy. I will check the restore in the next days and if it works I will send you a pull request.

from tmux-resurrect.

Okay that was easier than thought. See pull request

from tmux-resurrect.

Hi, thanks so much, this is great!

I saw the pull request last night, glanced over the code, but I thought to myself "it can't be this simple"..
But it works, with just a few lines of code and it's a really elegant solution!

Btw. I also wanted to update the changelog (I credited you as the feature creator) and the readme so I merged this pull request via the command line.

This pull req made my day!

from tmux-resurrect.

Thanks for the nice words. Keep up the good work.

from tmux-resurrect.