Code Monkey home page Code Monkey logo

Comments (3)

tmcw avatar tmcw commented on August 19, 2024

This module relies heavily on module-deps for parsing, and that module unfortunately doesn't support many ES6isms and isn't getting any significant maintenance. I'll likely deprecate this module, especially because ES6 import/export syntax supports circular requires.

from circular-require.

vbraun avatar vbraun commented on August 19, 2024

Circular requires were allowed also before ES6, your milage depends a bit on how you consume them (e.g. nodejs vs. browserify).

They remain a bad idea, in particular they can cough up mysterious errors at import time that are hard to track down once your dependency graph is lange enough. Apart from general code smell and unclear responsibilites, of course. Nothing special to Javascript or ES5/6/(n+1), also holds true for Python or any other dynamic language.

from circular-require.

tmcw avatar tmcw commented on August 19, 2024

Yep, that's true and afaik this module doesn't claim they're forbidden or disallowed. ES6 import/export syntax is materially different in its handling of cyclical dependencies and the spec is much clearer about behavior - but, sure, still a bad idea.

That said, this is a wontfix issue on an up-for-adoption repo, so... closing.

from circular-require.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.