"additionalProperties" in "allOf" does not work about enjoi HOT 4 CLOSED

This is probably going to be a documented limitation of how allOf will work with Joi. allOf is not a combination of the defined schemas, but rather a validation against all provided schemas.

To allow this to work, allOf must always allow additional properties so that it may continue checking.

With access to more of the job error API we could get more custom about avoiding this sort of decision making but for now it's probably harder.

Will think through it some more.

from enjoi.

Oh, I missed that. It seems also a limitation of JSON Schema too, and this exact example is given in doc's combining schemas section

It may be added in next versions of JSON Schema...

This shortcoming is perhaps one of the biggest surprises of the combining operations in JSON schema: it does not behave like inheritance in an object-oriented language. There are some proposals to address this in the next version of the JSON schema specification.

from enjoi.

As a workaround, in my particular case at hand, I will try to add an optional preprocess step to convert allOf to non cascading schema. (They are not equivalent as per JSON Schema spec, but equal for my needs)

Using this function:

// CAVEAT: This is NOT a general solution, just a workaround, and not thoroughly tested.
function flattenAllOf(schema) {
  if (!schema.allOf) {
    return schema;
  }

  let properties = schema.properties || {};
  schema.allOf.forEach(element => {
    properties = { ...properties, ...flattenAllOf(element).properties };
  });

  return {
    type: "object",
    properties,
  };
}

From:

{
  allOf: [
    {
      allOf: [
        {
          type: "object",
          properties: {
            a: { type: "string" },
            b: { type: "string" },
          },
        },
        {
          type: "object",
          properties: {
            c: { type: "string" },
            d: { type: "string" },
          },
        },
      ],
    },
  ],
};

to

{
  type: "object",
  properties: {
    a: { type: "string" },
    b: { type: "string" },
    c: { type: "string" },
    d: { type: "string" },
  },
},

from enjoi.

Cool, and thanks for the feedback!

I appreciate the issues - helps me get insight into things I missed.

from enjoi.