Empty string '' for subdomain about django-subdomains HOT 4 OPEN

I believe that this is the issue that I ran into. It is fixed by pull request #54. The issue is that there is a check:

if subdomain is '':

which I changed to:

if subdomain == '':

since the object 'subdomain' is a Django class, rather than a plain string.

from django-subdomains.

@jbmmhk
Looks like slightly different issues. But your fix looks absolutely reasonable for me and I hope that @tkaemming will merge it eventually.

the object 'subdomain' is a Django class, rather than a plain string.

Not exactly. If you look there
https://github.com/tkaemming/django-subdomains/blob/master/subdomains/middleware.py#L39
request.subdomain contains string from matched regexp.

from django-subdomains.

You are correct that the issue is separate from mine, the issue that I ran into was in regards to the reverse template tag. (In which case the 'subdomain' string is a SafeString from Django).

from django-subdomains.

@jbmmhk didn't thought about SafeString. Thanks for the explanation!

from django-subdomains.