Code Monkey home page Code Monkey logo

Comments (9)

TrySound avatar TrySound commented on May 18, 2024 1

How exactly random attribute bugs you? It's just used to prevent deletion of previously defined tags with the same attributes as defined by react-head.

from react-head.

TrySound avatar TrySound commented on May 18, 2024 1

There is a mention in this comment about these attributes shouldn't affect software outside of the site. So maybe we should open issues in failed validators.

People also mention google AMP breaking. I wonder to know why they use react in AMP which is a kind of framework without scripts or something.

from react-head.

tizmagik avatar tizmagik commented on May 18, 2024 1

Thanks @CanRau

from react-head.

CanRau avatar CanRau commented on May 18, 2024

it bugs people in the mentioned comment nfl/react-helmet#79 (comment) and I'm not sure how real it is for SEO as some worry..
probably it's not a thing..

from react-head.

CanRau avatar CanRau commented on May 18, 2024

they're probably generating AMPs using react?!

from react-head.

tizmagik avatar tizmagik commented on May 18, 2024

Using React for AMP pages is a good use case (we currently do this at NYT), but in that case, since you don't care about the client-side head tags being updated (not much if any client-side JS executes) you can regexp the data attribute out before sending the server markup.

Otherwise, as @TrySound suggested, this attribute is used so react-head knows which tags it's responsible for updating/removing. I'm not sure of another way to do this same thing.

from react-head.

CanRau avatar CanRau commented on May 18, 2024

So the issue can be closed if those attributes have no impact 👍

@TrySound yeah I had thought about validator issues rather than "real" problems, too 🥇

from react-head.

outofthisworld avatar outofthisworld commented on May 18, 2024

Can you generate hash to identify instead of a data attribute?

from react-head.

TrySound avatar TrySound commented on May 18, 2024

And where do you suggest to store this hash?

from react-head.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.