Comments (7)
I've also noticed that the linter fails during development, specifically in the LocalForageService using the let
keyword and then never reassigning the variable.
Additionally, there are several violations I've noticed in the angular styleguide.
I'll be submitting a pull request shortly.
from ngx-localforage.
@radyz @Xepe Is this repository dead? I can make my own npm package and maintain it if it is.
from ngx-localforage.
Hello @paynoattn,
Thanks for report the issue.
No it is not dead, I will try to review the issue this night.
Thanks.
from ngx-localforage.
Awesome, there is already a PR #8.
from ngx-localforage.
@Xepe any progress?
from ngx-localforage.
Looks like my PR was merged, are we going to merge to master and deploy?
from ngx-localforage.
Hello @paynoattn,
It is in master with version 0.1.35
Thanks for all.
Regards.
from ngx-localforage.
Related Issues (8)
- Multiple Instances
- Multiple stores HOT 2
- I got TypeError: this.localForage.setItem is not a function when run unit test
- Add support for Angular6
- [Example] Can you provide an example to create an instance of localforage using LocalForageFactory and LocalForageToken
- How Do I Connect This ?
- general help HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-localforage.