VCR may block download of chromedriver about webdrivers HOT 5 CLOSED

@lordofthedanse Thanks for reporting that. A better way might be to explicitly list the S3 host in allowed_sites:

allowed_sites = [
  "https://chromedriver.storage.googleapis.com",
  "https://github.com/mozilla/geckodriver/releases",
  %r{/^https:\/\/github-production-release-asset-.+\.s3\.amazonaws\.com/} # For geckodriver
  "https://selenium-release.storage.googleapis.com",
  "https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver"
]

If this is too broad (eg: You have other GitHub assets that you want to block), we can restrict the match by adding .+filename=geckodriver to the Regex above. Let me know if this works and I'll update the wiki.

from webdrivers.

Hi @pnikrat, thanks for this information. I have added it to the wiki - https://github.com/titusfortner/webdrivers/wiki/Using-with-VCR-or-WebMock

I have also added a link to the wiki in the README to let the users know it exists now.

from webdrivers.

Hi, I had the same issue with WebMock. The fix was similar:

allowed_sites = [
  "https://chromedriver.storage.googleapis.com",
  "https://github.com/mozilla/geckodriver/releases",
  "https://selenium-release.storage.googleapis.com",
  "https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver"
]

WebMock.disable_net_connect!(allow_localhost: true, allow: allowed_sites)

from webdrivers.

I appreciate you guys sharing this information! Updated the wiki page - https://github.com/titusfortner/webdrivers/wiki/Using-with-VCR-or-WebMock

from webdrivers.

@mike1o1 @kapoorlakshya I actually had to use a regex for geckodriver (a second request was being shot off for a tarball at an s3.AWS site). This is kind of a pain because WebMock (maddeningly) suggests stubbing the request to https://github.com/mozilla/geckodriver/releases, even after it is whitelisted (because of the second failure).

Unfortunately, the only term that’s shared between the two requests is gecko (AWS link below):

https://github-production-release-asset-2e65be.s3.amazonaws.com/25354393/2c0dc800-234f-11e9-8b9d-d8a1e36cb2c3?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A/20190430/us-east-1/s3/aws4_request&X-Amz-Date=20190430T132120Z&X-Amz-Expires=300&X-Amz-Signature=2769cf8c4d27aca791398c17e8673b6607312daed49bd9ec367921376dbdc739&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename=geckodriver-v0.24.0-macos.tar.gz&response-content-type=application/octet-stream

so I would recommend amending the Wiki to suggest something like ...

allowed_sites = [
  "https://chromedriver.storage.googleapis.com",
  %r{/geckodriver/},
  "https://selenium-release.storage.googleapis.com",
  "https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver”
]

from webdrivers.