Setup Husky pre-commit hook about tinyhttp HOT 8 CLOSED

@talentlessguy Is this issue still open? If it is can I work on it ?

from tinyhttp.

@rocktimsaikia yes it is, made this one for myself, but it's ok if you do it.

I want to setup a pre-commit hook that would run a linter and tests before commiting

So we should make a lint npm script with eslint ./**/*/src/*.{ts,js} (or any other glob to match all ts and js code)

Also make a script to run linter and tests, e.g. pre-commit script maybe (any other name would fit)

Then, install husky, and run this script on pre commit

from tinyhttp.

@talentlessguy Right. I also had the same idea. Currently, it does not have a separate script for linting so I was gonna create the script and add it to the pre-commit hook along with the test script. But I was not sure about adding the build scripts so waited for your comment before doing any more work on that

from tinyhttp.

@talentlessguy For some reason, most of the tests are failing even tho I haven't even changed any of the code yet. Just running the test script alone logs a ton of failing tests. Also, I did follow the installation guide provided here so not sure what's causing the tests to fail. Can you tell what might be causing these errors ?

from tinyhttp.

@rocktimsaikia the reason why tests fail is that I need to update the contributing guide...

try running pnpm i -r and pnpm build -r, these should work

from tinyhttp.

@talentlessguy I already tried all of the command solutions. But still the same. Do I need to specifically set some env file configs to run it locally? I think some of the packages are not building upon running the build command. Probably that's why It can't find its corresponding type declarations !!

from tinyhttp.

@rocktimsaikia try reloading TS Server (Ctrl + Shift + P -> Reload TS Server) in VS Code

from tinyhttp.

Closed with #53 🚀

from tinyhttp.