Code Monkey home page Code Monkey logo

Comments (3)

gianarb avatar gianarb commented on May 28, 2024

I made some investigation that I have to validate yet.
Docker Compose supports by default a .env file, if it exists all the docker-compose commands will read it.
This is a good place where we can place something like this:

export OSIE_DOWNLOAD_LINK=https://tinkerbell-oss.s3.amazonaws.com/osie-uploads/osie-v0-n=252,c=bc454bc,b=master.tar.gz
export TINKERBELL_TINK_SERVER_VERSION=quay.io/tinkerbell/tink:sha-adb49da
export TINKERBELL_TINK_CLI_VERSION=quay.io/tinkerbell/tink-cli:sha-adb49da
export TINKERBELL_TINK_BOOTS_VERSION=quay.io/tinkerbell/boots:327-58ab49913b5498908b16e2607d265a61a05f73b6
export TINKERBELL_TINK_HEGEL_VERSION=quay.io/tinkerbell/hegel:196-fa897aa020769db8becb9be29adaeb6be92a7fc7
export TINKERBELL_TINK_WORKER_VERSION=quay.io/tinkerbell/tink-worker:sha-adb49da

Now, we already have a envrc file, and my proposal is to move from envrc to .env. In this way the setup will look like:

./generate-envrc.sh eth0
source .env
./setup.sh
docker-compose up -d

If you need to change which version of tink-server gets loaded you can open the .env file and set the required docker image tag.

I like the idea to have a single env file for everything, we can keep the envrc but it will require a new flag when using docker-compose, and it makes that a bit less intuitive.

from playground.

thebsdbox avatar thebsdbox commented on May 28, 2024

This seems like an oversight in the first instance, the .env (not sure if it's a standard) however it is already a largely accepted method in various libraries to import variables into another running environment. So this sounds great to me.

from playground.

gianarb avatar gianarb commented on May 28, 2024

we did it!

from playground.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.