Comments (8)
Tinche
commented on May 10, 2024
Agreed, could you create a quick PR?
from aiofiles.
gyermolenko
commented on May 10, 2024
Agreed, could you create a quick PR?
related #54 (! please note that it also changes return type of the wrapped func)
from aiofiles.
HacKanCuBa
commented on May 10, 2024
Agreed, could you create a quick PR?
Sure, give me 5' :)
from aiofiles.
HacKanCuBa
commented on May 10, 2024
Done in #75
from aiofiles.
HacKanCuBa
commented on May 10, 2024
Agreed, could you create a quick PR?
related #54 (! please note that it also changes return type of the wrapped func)
Woops, sorry I missed this. Both PRs clashes, so I guess we need to pick one.
from aiofiles.
HacKanCuBa
commented on May 10, 2024
I saw that Travis failed in my PR so I checked out the project locally and saw that, at least for py3.8, tests are failing for what is mentioned in #54. With that patch all tests passed.
So, all in all, I think we need to go for #54, which is more complete and fixes other issue, instead of my patch.
from aiofiles.
Tinche
commented on May 10, 2024
Merged that one in! Can this issue now be closed?
from aiofiles.
HacKanCuBa
commented on May 10, 2024
Sure do! I'm closing it. Thanks!
from aiofiles.
Related Issues (20)
- Why jumping from v0.8 to v22.0 HOT 8
- FR: support os.access() HOT 2
- not found function HOT 8
- Does aiofiles.write support to write a new line for each message? HOT 3
- NamedTemporaryFile doesn't have ... a name? HOT 2
- What is the purpose of binding each file to a particular loop? HOT 1
- ModuleNotFoundError: No module named 'aiofiles.threadpool' HOT 1
- Release 22.2.0? HOT 1
- Cancel a pending open() call HOT 1
- Version compatibility v0.8.0 and v23.1.0 HOT 1
- *importlib.resources* support HOT 2
- add "aiofiles.path.walk" or "aiofiles.path.listdir" HOT 1
- How to create NamedTemporaryFile without the context manager? HOT 2
- It doesn't work to read pdf files? HOT 3
- Possible bug: unclosed file warning HOT 2
- Python 3.12 test failures: FAILED tests/test_tempfile.py::test_named_temporary_file[r+] - AttributeError: '_io.TextIOWrapper' object has no attribute 'delete' HOT 11
- Async os.walk attempted solution HOT 1
- statvfs is not available on windows HOT 3
- [Bug] os.statvfs is only available on Unix-like systems HOT 1
- Compatibility with `CloudPath` class in `cloudpathlib`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aiofiles.