Latest master cannot build with mvn about cointrader HOT 44 OPEN

still some problem with the REPO:
1: double dependencies of org.apache.commons:commons-math3:jar in the pom : have to delete the oldest one (version 3.2)
2: dependencies with TestStrategy are still there: Have to delete ALL the Strategy classes which extends TestStrategy
3: jep librairies still not compiled: have to instal the 3.7.0 version with a maven install command line
4: some Errors on the assembly plugin but the jar are generated anyway with a mvn clean install

==> Contributors should clean up the entire project and set a TAG on the REPO...

Thanks anyway this tool seems very promising

from cointrader.

setup instrutions dont fix the problem: the jep library cant be found in any maven repository so we have to install it manually in the local maven repository SO from step 5 of the Setup chapter we have to follow these instructions:
6. Download Jep source code at https://pypi.python.org/pypi/jep and extract the tar.gz file
7. cd in the freshly extracted jep-3.7.0 directory, build the jep-3.7.0.jar file following instructions of jep README
8. cd build/java and check out the freshly build of jep-3.7.0.jar
9. mvn install:install-file -Dfile=jep-3.7.0.jar -DgroupId=org.python.pypi -DartifactId=jep -Dversion=3.7.0 -Dpackaging=jar
10. update the pom.xml of cointrader:

org.python.pypi
jep
3.7.0

11. cd to cointrader root directory
mvn

from cointrader.

Hi, I am new to this and still try to make sens of it.
I fallowed successfully all 11 steps (thx dsissoko), but still have the exact same error while build with maven "mvn".

Does someone have any idea?

Ubuntu 16.04.3; Maven 3.3.9; jep-3.7.0.jar build with python2.7.12; JDK java-8-oracle

ERROR:
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.cryptocoinpartners:cointrader:jar:0.3.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.commons:commons-math3:jar -> version 3.2 vs 3.6.1 @ line 189, column 13
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building cointrader 0.3.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- antlr4-maven-plugin:4.2.2:antlr4 (antlr) @ cointrader ---
[INFO] ANTLR 4: Processing source directory /home/allex/cointrader/src/main/antlr4
[INFO] Processing grammar: org/cryptocoinpartners/command/Order.g4
[INFO] Processing grammar: org/cryptocoinpartners/command/Csv.g4
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cointrader ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 16 resources
[INFO] Copying 4 resources
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ cointrader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 266 source files to /home/allex/cointrader/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/MarketMakerStrategy.java:[48,42] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/BaseVolatilityStrategy.java:[63,54] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/CorrelationStrategy.java:[30,42] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/ProbabilityTrendStrategy.java:[52,47] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/MovStrategy.java:[30,34] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/PairsStrategy.java:[52,36] cannot find symbol
symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/RunsStrategy.java:[36,35] cannot find symbol
symbol: class TestStrategy
[INFO] 7 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.877 s
[INFO] Finished at: 2017-09-27T14:17:23+02:00
[INFO] Final Memory: 31M/247M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project cointrader: Compilation failure: Compilation failure:
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/MarketMakerStrategy.java:[48,42] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/BaseVolatilityStrategy.java:[63,54] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/CorrelationStrategy.java:[30,42] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/ProbabilityTrendStrategy.java:[52,47] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/MovStrategy.java:[30,34] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/PairsStrategy.java:[52,36] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] /home/allex/cointrader/src/main/java/org/cryptocoinpartners/module/RunsStrategy.java:[36,35] cannot find symbol
[ERROR] symbol: class TestStrategy
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

from cointrader.

it looks like TestStrategy was not included in the git... where can we get it?

from cointrader.

from cointrader.

from cointrader.

ok. but now it is different
cointrader/src/main/java/org/cryptocoinpartners/module/MockTicker.java:[14,11] package jep does not exist

from cointrader.

from cointrader.

from cointrader.

jep jar downloaded by maven contains java files (source code) but not compiled class files.

from cointrader.

from cointrader.

ok.
cointrader/repo/org/python/pypi/jep/3.6.1/jep-3.6.1.jar contains source files and not class files
As of my understanding, org/python/pypi/jep package requires native libraries for proper operation
However, in the local mavev "repo" there is only native library for macos for python version 2.7, what about Linux or other python versions? Project org/python/pypi/jep does not support installation via maven. org/python/pypi/jep declined proposal to support an installation via maven as there are too many native dependencies. Maybe, it is better to follow the 'official' way of library installation?

or to remove dependency on Python at all...

from cointrader.

from cointrader.

Here is how I solved JEP issues (on Windows):

• installed JEP using pip: pip install jep (NOTE: I used the latest available version 3.6.4 - https://pypi.python.org/pypi/jep)
• created repo\org\python\pypi\jep\3.6.4
• copied JAR from Python site-packages (...Python36\Lib\site-packages\jep\jep-3.6.4.jar) to this directory
• created repo\org\python\pypi\jep\3.6.4\jep-3.6.4.pom based on repo\org\python\pypi\jep\3.6.1\jep-3.6.1.pom - just replaced 3.6.1 with 3.6.4
• changed dependency in main pom.xml:

		<dependency>
			<groupId>org.python.pypi</groupId>
			<artifactId>jep</artifactId>
			<version>3.6.4</version>
		</dependency>

I believe the same could have been done with original version 3.6.1.

Hope that helps.

from cointrader.

BTW, I still couldn't find TestStrategy anywhere, so I temporarily remove the following from src\main\java\org\cryptocoinpartners\module to pass maven build without error:

BaseMomentumStrategy.java
BaseVolatilityStrategy.java
CarryStrategy.java
CorrelationStrategy.java
MarketMakerStrategy.java
MomentumStrategy.java
MovStrategy.java
PairsStrategy.java
ProbabilityTrendStrategy.java
RunsStrategy.java

@douggie Where can I find checked in TestStrategy ?

from cointrader.

from cointrader.

It does not appear that /src/main/java/org/cryptocoinpartners/module/TestStrategy.java was ever in the repo. It looks like it's on your machine and you didn't do a git add on it.

It's the abstract base class for all of the strategy modules. Can't build without it. Can you add it to the repo, please?

from cointrader.

from cointrader.

I agree. It is not in repo and it has never been as far as I can see. That's not the problem.

The problem is that these classes all derive from it and they ARE in the repo. So it cannot build because TestStrategy.java is missing:

in /src/main/java/org/cryptocoinpartners/module/

BaseMomentumStrategy.java
BaseVolatilityStrategy.java
CarryStrategy.java
CorrelationStrategy.java
MarketMakerStrategy.java
MomentumStrategy.java
MovStrategy.java
PairsStrategy.java
ProbabilityTrendStrategy.java
RunsStrategy.java

from cointrader.

from cointrader.

from cointrader.

@dsissoko any luck with building this java project? Could you pls submit a PR maybe then? Or share prebuilt project with zip :)

from cointrader.

you can follow the 4 steps stated in my previous comments and u will get a fresh build in the target directory.
OFC you need first to have JDK and MAVEN available in your user PATH

for the jep library you can follow the comment of LeonidShamis posted earlier

from cointrader.

Guys I haven't been actively maintaining this for years now. Douggie took over for a while, but maybe he's also moved on, not sure. I can comment here and there but don't really have time. If anyone wants to pick this project up, I'm happy to add contributors. Notice the wiki here on github too... I put some effort into docs outside the readme

from cointrader.

from cointrader.

happy to have some news here from tim and douggie. hope this setup issues will be soon fixed.

from cointrader.

from cointrader.

If you just want to try it out without the hassle - it was building back here: 214c976

from cointrader.

I am getting the following error in when running mvn

$ mvn
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building cointrader 0.3.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- antlr4-maven-plugin:4.2.2:antlr4 (antlr) @ cointrader ---
[INFO] ANTLR 4: Processing source directory C:\Users\faize\cointrader\src\main\antlr4
[INFO] Processing grammar: org\cryptocoinpartners\command\Order.g4
[INFO] Processing grammar: org\cryptocoinpartners\command\Csv.g4
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cointrader ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 16 resources
[INFO] Copying 4 resources
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ cointrader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 266 source files to C:\Users\faize\cointrader\target\classes
[INFO] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/module/ProbabilityTrendStrategy.java: C:\Users\faize\cointrader\src\main\java\org\cryptocoinpartners\module\ProbabilityTrendStrategy.java uses or overrides a deprecated API.
[INFO] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/module/ProbabilityTrendStrategy.java: Recompile with -Xlint:deprecation for details.
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[17,37] reference to Module is ambiguous
both interface com.google.inject.Module in com.google.inject and class java.lang.Module in java.lang match
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[44,34] cannot find symbol
symbol: class Field
location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[64,23] cannot find symbol
symbol: class Field
location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[INFO] 3 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.313 s
[INFO] Finished at: 2017-12-29T22:07:46+04:00
[INFO] Final Memory: 32M/106M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project cointrader: Compilation failure: Compilation failure:
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[17,37] reference to Module is ambiguous
[ERROR] both interface com.google.inject.Module in com.google.inject and class java.lang.Module in java.lang match
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[44,34] cannot find symbol
[ERROR] symbol: class Field
[ERROR] location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[64,23] cannot find symbol
[ERROR] symbol: class Field
[ERROR] location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

from cointrader.

from cointrader.

from cointrader.

from cointrader.

Hi Douggie

I am still getting the same problem along with some new ones.

I am getting this error now.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project cointrader: Compilation failure: Compilation failure:
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/module/xchange/OKCoinHelper.java:[9,42] cannot find symbol
[ERROR] symbol: class OkCoinPriceLimit
[ERROR] location: package org.knowm.xchange.okcoin.dto.trade
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[17,37] reference to Module is ambiguous
[ERROR] both interface com.google.inject.Module in com.google.inject and class java.lang.Module in java.lang match
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

from cointrader.

from cointrader.

Attempting to build and still running into the same errors regarding TestStrategy as described many times in this thread. Tried just deleting all the files inheriting from the missing TestStrategy file and still getting a jep error as described previously. Going to try to fix jep now...

from cointrader.

replacing the jep entry in pom.xml with:

<dependency>
    <groupId>black.ninia</groupId>
    <artifactId>jep</artifactId>
    <version>3.7.0</version>
</dependency>

has allowed me to at least get a clean mvn build

from cointrader.

console now just pukes errors everywhere like:

2018-01-02 21:44:31 [main] DEBUG o.cryptocoinpartners.module.Context - no module file found for XchangeData.epl on classpath. Please ensure XchangeData.epl is in the resources directory.

did a previous step in the setup instructions fail silently?

from cointrader.

from cointrader.

Hi,

Thanks for the pom update, I have pushed the corresponding updates with some default logging changes too.

from cointrader.

Hi Douggie

This is th error now

[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building cointrader 0.3.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- antlr4-maven-plugin:4.2.2:antlr4 (antlr) @ cointrader ---
[INFO] ANTLR 4: Processing source directory C:\Users\faize\cointrader\src\main\antlr4
[INFO] Processing grammar: org\cryptocoinpartners\command\Order.g4
[INFO] Processing grammar: org\cryptocoinpartners\command\Csv.g4
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cointrader ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 16 resources
[INFO] Copying 4 resources
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ cointrader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 266 source files to C:\Users\faize\cointrader\target\classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[44,34] cannot find symbol
symbol: class Field
location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[64,23] cannot find symbol
symbol: class Field
location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.299 s
[INFO] Finished at: 2018-01-08T21:47:56+04:00
[INFO] Final Memory: 30M/323M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project cointrader: Compilation failure: Compilation failure:
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[44,34] cannot find symbol
[ERROR] symbol: class Field
[ERROR] location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] /C:/Users/faize/cointrader/src/main/java/org/cryptocoinpartners/util/LogInjector.java:[64,23] cannot find symbol
[ERROR] symbol: class Field
[ERROR] location: class org.cryptocoinpartners.util.LogInjector.MyMembersInjector
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

from cointrader.

from cointrader.

Hi Douggie

I do see the MyMembersInjector, and i am using Java 8 to complie.

package org.cryptocoinpartners.util;

import com.google.inject.*;
import com.google.inject.matcher.Matchers;
import com.google.inject.spi.TypeEncounter;
import com.google.inject.spi.TypeListener;
import com.google.inject.util.Providers;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**

• @author Tim Olson
  */
  public class LogInjector implements Module {

  @OverRide
  public void configure(Binder binder) {
  // SLF4J logger injection
  binder.bind(Logger.class).toProvider(Providers.of(dummyLogger));
  binder.bindListener(Matchers.any(), new MyTypeListener());
  }

  private static class MyTypeListener implements TypeListener {

   @Override
   public <I> void hear(TypeLiteral<I> typeLiteral, TypeEncounter<I> typeEncounter) {
       for( Class<?> c = typeLiteral.getRawType(); c != Object.class; c = c.getSuperclass() ) {
           for( final Field field : c.getDeclaredFields() ) {
               if( field.getType().isAssignableFrom(Logger.class)
                           && field.isAnnotationPresent(Inject.class) ) {
                   typeEncounter.register(new MyMembersInjector<I>(field));
               }
           }
       }
   }
  

  }

  private static class MyMembersInjector implements MembersInjector {
  public MyMembersInjector(Field field) {
  this.field = field;
  }

   public void injectMembers(I i) {
       try {
           boolean wasAccessible = field.isAccessible();
           field.setAccessible(true);
           if( field.get(i) == null ) {
               field.set(i, LoggerFactory.getLogger(field.getDeclaringClass()));
           }
           field.setAccessible(wasAccessible);
       }
       catch( IllegalAccessException e ) {
           e.printStackTrace();
       }
   }
  
  
   private final Field field;
  

  }

  private static final Logger dummyLogger = LoggerFactory.getLogger("");

from cointrader.

from cointrader.

Hi Douggie

Im not sure what you mean by that. I am getting the error in the command. I have installed Netbeans, and i am also getting the error when trying to build the project in netbeans.

from cointrader.