Comments (6)
Amounts fixed in 23ea70c
The problem was that we had to use the "unscaled" amounts from the original edge here, as we explode to new unit processes. In contrast, the amounts from the timeline are scaled to match the FU.
from timex.
Nvm, found the sum_inter_duplicates flag in bwp.create_datapackage()
from timex.
From the datapackage-creation-side, this should be fixed in b84644f
However, the results are still wrong. But I think the problem might be in the timestamps in the timeline df.
from timex.
- Fixed amounts
- Added tests
from timex.
Additional problem came to my attention:
The setting: A foreground node (H2) links to a background node (el. mix) via a TD.
What happens in our code atm is that we don't link from H2 to exploded versions of el-mix, but link directly to the different available version of this process in the background dbs via interpolation. However, if two of these interpolations point towards the same background process, the matrix entry we add gets overwritten each time.
I'm pretty sure I talked about this with @cmutel at the Autumn School and he said that the default behavior of Datapackage.add_persistent_vector is to add the values instead of overwriting them - which seems to not be the case.
@jakobsarthur do you happen to know if changing this behavior is possible? Going through Datapackage.add_persistent_vector() I couldn't find what we need..
from timex.
Great! I will check the timestamps of the timeline. Still working on that, also in issue #5.
from timex.
Related Issues (20)
- update tests to new API HOT 1
- dynamic LCIA with fixed time horizon gives an error when TH is shorter than the timing of an emission
- Dynamic characterisation bug with latest bw2data and ecoinvent 3.10 HOT 1
- substitution exchanges are not recognized HOT 2
- refactor dynamic characterisation functions HOT 1
- non-unitary foreground unit processes are not scaled HOT 2
- Dependency Dashboard
- check types in characterization_function_dict HOT 2
- Prevent redundant calculations in dynamic_biosphere_builder
- Generalize DynamicCharacterization interface HOT 1
- Create self-contained example nb HOT 1
- [source] link not showing in documentation HOT 1
- add static lcia score for from_timeline approach HOT 1
- dynamic biosphere can not deal with absolute datetime in biosphere exchanges HOT 3
- build_timeline() can not deal with absolute datetime distributions in technosphere exchanges HOT 1
- dynamic biosphere builder adds dynamic_biomatrix entries multiple times if time-mapped producer is multiple times in the timeline HOT 1
- Restructure node_id_collection_dicts HOT 1
- datetime calculations + aggregation can lead to wrong timestamp HOT 2
- Multiple databases with the same timestamp in database_date_dict don't work
- Temporal grouping has to match the time resolution of TemporalDistribution
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from timex.