"increment" option on zoom range is not being obeyed about panzoom HOT 6 CLOSED

Thanks for creating an issue.

The zoom range increment is determined by the step attribute on the range input. While the plugin does set a default when the input is passed into the plugin for binding, it doesn't mean it can't be changed by setting the attribute on the input. That was my thinking when I wrote that, but maybe it would be helpful to have that as a separate option. It can't really be the increment option as that usually needs to be a larger number. The default step for the range input is 0.05, while the zoom increment defaults to 0.3. Another idea would be for me to not set that attribute at all if a step attribute already exists. Thoughts?

from panzoom.

I am probably misunderstanding something, your patience is appreciated!

This is the range control in my HTML:

<input id="zoom-range" type="range" min="1" max="5" step="1" value="1">

My panzoom code:

$myJqObject.panzoom({
    $zoomIn: $("#zoom-in"),
    $zoomOut: $("#zoom-out"),
    $zoomRange: $("#zoom-range"),
    $reset: $("#zoom-reset"),
    increment: 1,
    minScale: 1,
    maxScale: 4,
    contain: 'invert'
}).panzoom();

When I leave your code as original, the zoom buttons work as expected, but the range control ignores the step value set in the control...rather than only being able to drag it in discreet chunks, it gains infinite range, and the zoom obeys the input, so rather than only zooming to "1", "2", "3" or "4", it goes in 0.05 increments.

If I change line 818 as I mention above, the range control does what I want, only move in discreet steps. Perhaps panzoom isn't picking up the step from the range control in my particular instance?

from panzoom.

@rogerlos Right, the problem is that when you initialise panzoom on the range input, it's overwriting the step attribute on that input. You could workaround this by setting it in code after you initialise panzoom, but my thoughts were, would you rather specify the step when initialising panzoom or would you rather panzoom simply not overwrite the step attribute that you already have on the input?

from panzoom.

or maybe both?

from panzoom.

Either way (or both!) would be fine, as long as there was a documented way to whip the range control into shape. Many thanks for your responsiveness. If it was both, I would prefer the initialization to take priority over the value set in HTML.

plugin default < HTML control < option set on init < setting it programatically

from panzoom.

Sounds reasonable. I'll have a patch soon.

from panzoom.