Refactor your .NET HTTP Clients to Typed HTTP Clients about timdeschryver.dev HOT 4 CLOSED

Hi, I usually use injected typed http clients, but today I stumbled on this advice

https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines#recommended-use

Using PooledConnectionLifetime with singleton instead of HttpClientFactory is new to me. I often use singleton registered services and hence have long lived instances, so according to the recommendations I linked, it would be better to use PooledConnectionLifetime instead of the HttpClientFactory.

What do you think?

from timdeschryver.dev.

Hi @snielsson good comment!
Using the singleton with PooledConnectionLifetime is fine when you just have a single service you need to communicate with.

I see a HTTP factory as a singleton that's managed by ASP.NET.
I also find it easier to use HTTP factories when you need to work with multiple services, as each client can be configured by its own needs without interfering with the other clients.

from timdeschryver.dev.

If you want to use a typed client in a singleton service, the recommened approach is using SocketsHttpHandler as the primary handler, and configuring the PooledConnectionLifetime.

Since the SocketsHttpHandler will handle connection pooling, you can disable recycling at the IHttpClientFactory level by setting HandlerLifetime to Timeout.InfiniteTimeSpan.

services.AddHttpClient<GitHubService>((serviceProvider, client) =>
{
    var settings = serviceProvider
        .GetRequiredService<IOptions<GitHubSettings>>().Value;

    client.DefaultRequestHeaders.Add("Authorization", _settings.GitHubToken);
    client.DefaultRequestHeaders.Add("User-Agent", _settings.UserAgent);

    client.BaseAddress = new Uri("https://api.github.com");
})
.ConfigurePrimaryHttpMessageHandler(() =>
{
    return new SocketsHttpHandler()
    {
        PooledConnectionLifetime = TimeSpan.FromMinutes(15)
    };
})
.SetHandlerLifetime(Timeout.InfiniteTimeSpan);

from timdeschryver.dev.

Neat, thanks for the info @ngoquoctoandev

from timdeschryver.dev.