Unable to clear the current running timer and exit the retry loop about node-retry HOT 4 CLOSED

Agreed! Nice find!

Would you like to PR this fix?

from node-retry.

Ok, I will fix it and raise a PR asap.

from node-retry.

So, How do you want the approach for this to be. Do I add this fix to the existing stop method as a bug fix, or do I add an additional method, which clears the timer as well as perform the current stop operation so that it does not break any thing in existing dependents?

from node-retry.

From the docs:

Allows you to stop the operation being retried. Useful for aborting the operation on a fatal error etc.

I think the documentation and the intended use implies that the timer is also aborted. I think if you change the existing stop() function that will be ok. We'll make it a minor upgrade (major if we'd be 1.0 already) instead of a semver patch.

from node-retry.