Code Monkey home page Code Monkey logo

Comments (18)

krlmlr avatar krlmlr commented on June 1, 2024 1

I think I'll add rbind.tbl_df() and make sure it behaves like the dplyr equivalent.

from tibble.

gavinsimpson avatar gavinsimpson commented on June 1, 2024 1

Can this be reconsidered/reopened? Part of the justification for tibble is so you don't need all of dplyr just to have the data frame goodness. As such tibble should provide a suite of tools for working with tibbles or tbl_dfs.

An rbind.tbl_df() would be a most useful addition to this package

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Does this mean copying the bind_rows() implementation from dplyr? This seems to need at least Collecter, SlicingIndex and set_rownames().

from tibble.

hadley avatar hadley commented on June 1, 2024

Yeah, I'm not sure how to deal with that. One option would be to add a dplyr dependency to tibble (just a suggest), but that seems suboptimal.

from tibble.

hadley avatar hadley commented on June 1, 2024

I think we can leave this for now.

from tibble.

hadley avatar hadley commented on June 1, 2024

Not in near future - there is a lot of code powering bind rows that we'd need to duplicate. All the variable coercion stuff is complicated.

from tibble.

gavinsimpson avatar gavinsimpson commented on June 1, 2024

Is it being considered for the longer term future? Closing this issue gave me the impression this wasn't something you were going to deal with.

I have no doubt this is complicated; if it were easy I suspect it would have been done by now.

from tibble.

hadley avatar hadley commented on June 1, 2024

In the long long term I'd like to move data frame stuff related here but it's probably at least a year away

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

I think we could do just what data.table does -- they're patching rbind.data.frame(): tidyverse/dplyr#606 (comment).

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Did we agree to not patch fix rbind() and cbind()?

from tibble.

hadley avatar hadley commented on June 1, 2024

I'd prefer not to mess with base R functions

from tibble.

github-actions avatar github-actions commented on June 1, 2024

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Let's retry, also with cbind(), now that we have vctrs.

from tibble.

hadley avatar hadley commented on June 1, 2024

👍

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Things appear to have changed for R 4.0.0, the relevant FAQ in data.table was updated. Are we ok with a solution that works only in R 4.0.0 now, should we postpone until the tidyverse requires R 4.0.0?

from tibble.

hadley avatar hadley commented on June 1, 2024

I think it's fine to add a solution that only works in 4.0.0 and up. That will help the majority of users.

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Done. I'll release to CRAN without it, we might want to do revdepchecks because users might rely on downcasting to data frames.

from tibble.

krlmlr avatar krlmlr commented on June 1, 2024

Do we still want this, given the complexities discussed in #909?

@DavisVaughan suggests to

link to vec_rbind() in the tibble::add_row() documentation. i.e. "If you would like to row bind multiple data frames together, see..."

Similar for vec_cbind() and tibble::add_column().

from tibble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.