Code Monkey home page Code Monkey logo

Comments (3)

ewanharris avatar ewanharris commented on September 22, 2024

I think maybe the run function might need changing to set an options argument that includes a cwd that is set to the project directory.

While that change should be made, I think to be safe the hook should also do something like the below rather than path.resolve. As path.resolve will work with the current working directory of the command which isn't always guaranteed to match the specified --project-dir command.

const projectBuildGradle = path.join(cli.argv['project-dir'], 'build', 'android', 'build.gradle');

from pulsar-titanium.

m1ga avatar m1ga commented on September 22, 2024

sounds good too! Didn't know that the parameters can just be grabbed like this cli.argv['project-dir'] 👍
Since VSCode was working correctly I thought it would be easier to have the run function to run in that folder as other hooks might be a problem too.
I'll test it with your example code, thanks

from pulsar-titanium.

jordanbisato avatar jordanbisato commented on September 22, 2024

Just a note:

The same occours on iOS using Firebase-Crashlytics for dsymPaths:

Atom:
/build/iphone/build/Products/Release-iphoneos

using the CLI inside the app folder or VSCode:
/Users/jordanbisato/Projetos/CVP-Aplicativo-Front/build/iphone/build/Products/Release-iphoneos ✔️

from pulsar-titanium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.