Path prompt with SoftwareProduct about poshspec HOT 9 CLOSED

I did not do a very good code review on this function. It has a number of issues and the whole thing should be redesigned. If anyone would like to take a stab at it, that would be great. Otherwise, I'll try to get to it shortly.

Issues:

• There are two parameter sets, but no code path for handling the "Property" set.
• The Exist assertion only works if you pass a Path to it. It's not functional with the currently designed $expression.
• In Pester Exists just calls Test-Path which does support string[] for -Path, but I haven't tested if Exist supports that. Either we need to test both Windows and WOW6432Node paths, or create a seperate function for SoftwareProduct32 to look in the 32bit path.

from poshspec.

@glaisne what version of poshspec are you using?

from poshspec.

I'm using 2.2.1. Accrding to repositorySourceLocation, I pulled it from powershellGallery.com.
My PS version is 5.1.15063.296, CLR is 4.0.30319.42000.

from poshspec.

Hi,

I encounter the same issue with:

PSVersion 5.1.17134.407
PSEdition Desktop
BuildVersion 10.0.17134.407
CLRVersion 4.0.30319.42000

Script poshspec
Version 2.2.2

from poshspec.

@cdhunt, given that -Exists feels more natural (even though it is specific to paths), I wonder if it would make sense to dynamically swap -Exists with -Not -NullOrEmpty within SoftwareProduct before calling Get-PoshspecParam. What do you think?

from poshspec.

@cdhunt, @markwragg is there a chance that you could publish a new version with this fix to the PSGallery?

from poshspec.

I can't currently publish new versions but Chris is going to give me access to do so will do after that.

from poshspec.

Fixed as of version 2.2.8 which has just been published to the gallery.

from poshspec.

Yay!!! Thanks a ton, @markwragg

from poshspec.