Comments (2)
I'm looking into this and have stored away the required html to make a fix for this.
The interesting thing with for instance Sir Pixxy is that the level is not present in the death entry. Thats why the regex is not catching that entry in the first place.
from tibiadata-api-go.
yeah - it seems like as it can't be logged as "died at level X by" because it was not classed as a PvE death, and it can't be logged as "killed at level X by" because after they remove "Assist" players from the list of killers, there are none, so it seems it just skips the "cause" part of the log (which is what includes the level) and prints the assists.
You can see this causes similar problems for other fansites too e.g. here: https://www.tibiaring.com/char.php?c=Sir+Pixxy it shows multiple deaths all at the same level because the level is omitted in this situation.
In an ideal world I'd love for Cip to change this behaviour so that the level the character dies at is printed, and it's clarified that it was a PvP death e.g. if the killers list is empty just write something vague "Killed at level X in player combat, Assisted by: Y". I feel like these two data points are "required fields" from the players perspective that should always be conveyed (somehow) in the death log. That's a matter for the proposals forum though!
from tibiadata-api-go.
Related Issues (20)
- Problem with highscores pages
- Endpoint for Drome leaderboards HOT 2
- Improve parsers efficiency HOT 1
- Creatures endpoint return race value straight from URL
- Bug: date format changed on world page
- World Creation Date Incorret HOT 1
- [bug] character deathlist timestamp parsing issue
- [bug] characters title throws atoi error on grade
- Fix codecov test issues HOT 1
- [bug] characters with too many deaths cause crash HOT 1
- Improve character deaths by adding truncated flag
- [bug] Increase max length of characters to 20
- /v4/killstatistics/* errors for newly created worlds HOT 2
- [bug] shorter character names like I
- Various `/news/id/*` responses have empty `content` and `content_html` HOT 7
- [bug] houses endpoint town-parameter failing when plus in name
- [bug] houses endpoint returns null on Ab'Dendriel
- Refactor suggestion: Wrap all responses on a data field HOT 1
- + character is being counted towards character name 'word limit'
- Wrong code status in "Character" and "World" endpoints HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tibiadata-api-go.