Failure, exiting: The source cluster was not shut down cleanly about docker-postgres-upgrade HOT 5 CLOSED

@tianon what to you think to add pg_ctl start + pg_ctl stop step before execute pg_upgrade to avoid The source cluster was not shut down cleanly error?

from docker-postgres-upgrade.

I found that running docker exec --user postgres POSTGRES bash -c "pg_ctl stop" worked --> where POSTGRES is the name of the original (and running) postgres container. Just make sure that docker (or docker-compose) is not setup to restart your container on failure.

I wonder if the container/docker runs pg_ctl stop with the 'immediate' directive, i.e. pg_ctl stop -m i?

from docker-postgres-upgrade.

This is how I fixed it:

docker run -it --rm -v `pwd`/:/var/lib/postgresql/ tianon/postgres-upgrade:9.4-to-12 bash
su postgres
$PGBINOLD/pg_ctl start -w -D $PGDATAOLD
$PGBINOLD/pg_ctl stop -w -D $PGDATAOLD
exit

Next I can start this with success:

docker run --rm -v `pwd`/:/var/lib/postgresql tianon/postgres-upgrade:9.4-to-12

from docker-postgres-upgrade.

Same commands in one line:

docker run -it --rm -v `pwd`/:/var/lib/postgresql/ tianon/postgres-upgrade:9.4-to-12 su postgres -c "\$PGBINOLD/pg_ctl start -w -D \$PGDATAOLD ; \$PGBINOLD/pg_ctl stop -w -D \$PGDATAOLD; /usr/local/bin/; /usr/local/bin/docker-upgrade"

from docker-postgres-upgrade.

Before:

docker run -it --rm -v `pwd`/:/var/lib/postgresql/ tianon/postgres-upgrade:9.4-to-12 su postgres -c "\$PGBINOLD/pg_ctl start -w -D \$PGDATAOLD ; \$PGBINOLD/pg_ctl stop -w -D \$PGDATAOLD; /usr/local/bin/; /usr/local/bin/docker-upgrade"

Don't forget to execute:

# chown 999 ./ -R

from docker-postgres-upgrade.