Code Monkey home page Code Monkey logo

Comments (12)

roganartu avatar roganartu commented on June 1, 2024 4

Switching from str | None = None to Optional[str] = None worked for me.

That is a pretty good workaround, but for me it means that I have to configure my linters one way for modules that use typer and another way for the rest of the code.

pyupgrade will respect type aliases, as will typer. It's unwieldy, but this means you can do the following without having to configure pyupgrade to keep runtime types:

OptionalStr = Optional[str]

main(
    foo: OptionalStr = typer.Argument(None),
) -> None:
    ...

from typer.

exislow avatar exislow commented on June 1, 2024 4

It would be great to use str | None instead of Optional[]. @tiangolo: Any plans to implement this to support >= Python3.11?

from typer.

johnthagen avatar johnthagen commented on June 1, 2024 2

For me, I'd rather use Optional[str] than making an alias named OptionalStr (that someone then has to look up to know exactly how it was defined).

I think the idea here is that we ideally want to use str | None as is the new, preferred style, that pyupgrade/Ruff also lint for.

from typer.

domef avatar domef commented on June 1, 2024

I'm having the same issue. Using Union[type1, type2] with from typing import Union leads to the same error.

from typer.

raminqaf avatar raminqaf commented on June 1, 2024

@tiangolo, Any updates on this feature?

from typer.

johnthagen avatar johnthagen commented on June 1, 2024

Related to

from typer.

pdonorio avatar pdonorio commented on June 1, 2024

Hi and thanks a lot for this great library!

I've run into this issue as well. May someone provide some guidance on what should be fixed,
in case someone would like to contribute to solve it?

from typer.

renardeinside avatar renardeinside commented on June 1, 2024

I have the same issue with Python 3.10. Any advisory on how to fix this?

from typer.

lucasgadams avatar lucasgadams commented on June 1, 2024

Switching from str | None = None to Optional[str] = None worked for me.

from typer.

toppk avatar toppk commented on June 1, 2024

Switching from str | None = None to Optional[str] = None worked for me.

That is a pretty good workaround, but for me it means that I have to configure my linters one way for modules that use typer and another way for the rest of the code.

from typer.

albertotb avatar albertotb commented on June 1, 2024

For me, I'd rather use Optional[str] than making an alias named OptionalStr (that someone then has to look up to know exactly how it was defined).

I think the idea here is that we ideally want to use str | None as is the new, preferred style, that pyupgrade/Ruff also lint for.

Agree, for now I've just disabled linting in that specific line, in Ruff you can do it with #noqa: UP007

from typer.

dolfandringa avatar dolfandringa commented on June 1, 2024

I am stuck between Typer not supporting the new python syntax with |None=None and pyupgrade refusing to add an option to skip code for a specific line. I guess I'll try this solution.....

Switching from str | None = None to Optional[str] = None worked for me.

That is a pretty good workaround, but for me it means that I have to configure my linters one way for modules that use typer and another way for the rest of the code.

pyupgrade will respect type aliases, as will typer. It's unwieldy, but this means you can do the following without having to configure pyupgrade to keep runtime types:

OptionalStr = Optional[str]

main(
    foo: OptionalStr = typer.Argument(None),
) -> None:
    ...

from typer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.