Trying to use Starlette DatabaseMiddleware about fastapi HOT 5 CLOSED

seems like I'm making a mistake on my

@fastapi.post("/notes")
async def add_note_fastapi(note: NoteIn, raise_exc: bool = False):

as the equivalent starlette style includes the @transaction decorator which I forgot to include:

@starlette.route("/notes_starlette", methods=["POST"])
@transaction
async def add_note_starlette(request):
    """
    Create a note: Starlette style
    """
    data = await request.json()
    query = notes.insert().values(text=data["text"], completed=data["completed"])
    await request.database.execute(query)
    if "raise_exc" in request.query_params:
        raise RuntimeError()
    return JSONResponse({"text": data["text"], "completed": data["completed"]})

Now it leads to another issue but it's a step closer, I'll have to rewrite a decorator that suits FastAPI, or use the Depends system if I got it right ?

from fastapi.

I replaced the @transaction that decorates the async def add_note_starlette(request): with a
async with fastapi.error_middleware.app.backend.session().transaction(): within the fastapi route that creates a note solves the rollback issue for this test only.

I added TestStarletteStyleWithFastAPI that uses the starlette route style (@app.route(path, methods=['POST'])) decorators with a FastAPI instance and all tests pass, it's a lots of duplicate code but it's a beginning trying to use that DBMiddleWare

So my struggle here is really how you decorate a fastapi route with this @transaction from starlette : using an aysnc with inside the route makes the rollback effective only during one test but subsequent tests fail.

from fastapi.

closing per #20 (comment)

from fastapi.

Thanks for coming back and closing it 👍

from fastapi.

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

from fastapi.