Some redundant steps on swarmpit recipe about dockerswarm.rocks HOT 10 CLOSED

Come to think of it, we do point each subdomain manually on prod since the some other subdomain is long been used for an important service. Thanks for the reply. All of the recipes here are very helpful.

from dockerswarm.rocks.

swarmpit.yml should also be updated for this PR swarmpit/swarmpit#319.

from dockerswarm.rocks.

The domain is needed, it is used by Traefik to generate HTTPS certificates for it. And it's used inside of the Docker Compose/Stack file: https://github.com/tiangolo/dockerswarm.rocks/blob/master/docs/swarmpit.yml#L27

from dockerswarm.rocks.

@tiangolo I mean this step https://github.com/tiangolo/dockerswarm.rocks/blame/master/docs/swarmpit.md#L19, I just point domain example.com, not each of the subdomains.

from dockerswarm.rocks.

Yep. But that doesn't work for everyone, not everyone set a wildcard domain with everything pointing to their cluster.

For example, someone might need to have a frontend deployed to Netlify, instead of the Docker Swarm mode cluster. So, a wildcard with *.example.com wouldn't work in this case.

Still, that's why it says:

[...] Make sure that your DNS records point [...]

As you might achieve that with a wildcard. It doesn't require you to create a new DNS record, just to make sure that it works before deployment.

from dockerswarm.rocks.

On this comment, there should be some mention of app being default service name so if the service name is changed it should be overridden by environment variable. I did not want to create PR before specifying the issue. ref: https://github.com/swarmpit/agent/blob/adff5c79871ee8f7edac3b61febb4b903aaba0e8/setup/args.go#L17

from dockerswarm.rocks.

Hmm, I'm not sure I understand what you mean...

from dockerswarm.rocks.

If the service name is not app such as if it is swarmpit-app, then swarmpit agent cannot connect to swarmpit. ref: swarmpit/swarmpit#319

from dockerswarm.rocks.

Hmm, I don't see a case where that would happen here.

from dockerswarm.rocks.

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.

from dockerswarm.rocks.