Code Monkey home page Code Monkey logo

Comments (9)

tiagob avatar tiagob commented on June 2, 2024 1

Thanks for your feedback! Glad to hear you like the project. Please don't hesitate to let me know what else you'd find useful. You're the first person to see this besides the people I've personally shown. Just out of curiosity, how'd you find out about it?

I made some changes to address your comments, https://github.com/tiagob/create-full-stack/pull/139/files

I defaulted the Fargate service port to 8080. I want to keep the generated pulumi-aws/index.ts files as simple as possible but it makes sense to allow additional configuration.

I renamed distFolder to buildPath which matches the naming in the project. It behaves just like you suggest.

I didn't include buildCommand. The standard build command didn't work for you? Did you get an error?

from create-full-stack.

tiagob avatar tiagob commented on June 2, 2024 1

Sounds like a lot of work. Glad you found it!

I would really appreciate a tweet + newsletter. Thank you! I'll let you know when it's ready. Thinking 1-2 weeks. What's the best way to notify you?

Since I'm trying to keep it as simple as possible for the 98% use case, I'm not going to include the buildCommand. If there are other examples in the future to support a custom build command, I'll add it then.

Re: expo-cli, I like that idea. I initially tried doing that but was having problems reaching the expo command when executing it in Pulumi. I could likely do something similar to require.resolve("yarn/bin/yarn") in syncWeb. I think it's ok as-is for now

from create-full-stack.

tiagob avatar tiagob commented on June 2, 2024 1

Merged and published the changes
[email protected]

from create-full-stack.

GavinRay97 avatar GavinRay97 commented on June 2, 2024 1

The Expo CLI thing would be neat if possible because I think it wound up being the majority of the packages dependency weight. If not, no big deal ¯_(ツ)_/¯

Thinking 1-2 weeks. What's the best way to notify you?

Awesome =D
Can email me at [email protected] or DM me on Twitter (GavinRayDev) if that's more convenient 👍

from create-full-stack.

GavinRay97 avatar GavinRay97 commented on June 2, 2024

It looks like second one about the RDS configuration was added few days ago so nevermind on that one 😅

from create-full-stack.

GavinRay97 avatar GavinRay97 commented on June 2, 2024

Just out of curiosity, how'd you find out about it?

Haha, super valid question. I basically searched Github for combinations of "pulumi", "hasura", and "fargate", and then manually combed through every repo result for hours, weeding out stuff of value.

Without a doubt this repo was the most useful and impressive. Kind of shocked me to see it had zero stars, though I see that's intentional now 😂

By the way, I'm a Technical Evangelist at Hasura -- if you're interested would love to tweet this repo out + put it in community newsletter whenever you feel it's ready. Think a lot of people could benefit from this.

The standard build command didn't work for you? Did you get an error?

No it totally would have! It was more of me just wanting to leave the command open-ended. I'm actually not using this with a React app, so some of the targeted stuff wasn't identical (the frontend I had deployed was a Vue SPA, which also uses yarn build, the backend is a Nest.js API).

The rest of the static website builder is pretty agnostic, the only thing that was locked in was that the build command assumes yarn build (which is probably true for 98% of apps), so while I was tweaking stuff I made it configurable.

But it really doesn't make a difference for my usecase either way to be honest.

from create-full-stack.

tiagob avatar tiagob commented on June 2, 2024

@GavinRay97 would splitting up the cfs-pulumi package help? I'm considering cfs-pulumi-aws, cfs-pulumi-auth0 and cfs-pulumi-expo. I'm assuming you're not using expo publish?

Using the expo-cli in a Pulumi dynamic provider is tricky since it runs in an AWS lambda function.

from create-full-stack.

GavinRay97 avatar GavinRay97 commented on June 2, 2024

Ahh could see that being thorny. The optimum situation would probably to have the packages be modular, so if someone isn't using Expo/RN it won't pull that dep in.

But if it makes managing the dependencies more difficult, may not be worth the effort.

from create-full-stack.

tiagob avatar tiagob commented on June 2, 2024

Done. I broke up cfs-pulumi into cfs-pulumi-aws, cfs-pulumi-auth0 and cfs-pulumi-expo

from create-full-stack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.