Batch: remove `is_empty` about tianshou HOT 24 CLOSED

@dantp-ai I have made some changes , but idk if it is correct or wrong , so let me send a pull request shortly and kindly can you go through it ?

from tianshou.

@dantp-ai check #1125
Seems like i kinda messed up , T_T

from tianshou.

@DarkTechPirate wanna have a look at this one? It's a fairly small thing and a good way to get started with contributing :)

from tianshou.

@MischaPanch yea sure

from tianshou.

Cool, thanks!

from tianshou.

can this also be changed into len(batch.get_keys()) == 0

from tianshou.

Not sure what you mean. How is this related to is_empty()?

from tianshou.

in 5th line we are using is_empty() to check it right!?
if we remove that fun it wont work , so we need to replace it with something right

from tianshou.

Yes, you're right, hadn't seen it. I think a full-text search of is_empty should reveal all usages, in case the find usages of your IDE misses some

from tianshou.

@MischaPanch I'd be glad to assist with this one for review in PR.

from tianshou.

@MischaPanch I'd be glad to assist with this one for review in PR.

Sounds good, thanks!

from tianshou.

@DarkTechPirate do you have an ETA for when you could submit a PR?

from tianshou.

@MischaPanch so can we have a goggle meet or something as soon all my doubts clear i can finish it in 1 or 2 hours , let me know is it even possible ?

from tianshou.

@dantp-ai hey sure , we shall also have a meeting when you are free , lmk

from tianshou.

I won't have time until the end of next week, but @dantp-ai knows what this issue is about, so if the two of you have time to talk to each other, that would be the fastest option :). It's not a big change

from tianshou.

@DarkTechPirate I'd be happy to help. We can look at it tomorrow.

from tianshou.

@MischaPanch Okay sure , we will finish it off asap

from tianshou.

Thank you two, highly appreciate it!

from tianshou.

@dantp-ai how to contact you , discord or you people use something else !?
its my first time working with someone , so sorry for inconvenience!

from tianshou.

@DarkTechPirate Once you have a solution (a work-in-progress is fine, though a complete solution is greatly appreciated), please open a PR and we can review the code together here on GitHub.

The above description of the issue is instructive and should contain all the hints. If you have any doubts, feel free to write them down here and I will be able to help you.

I assume you have already read the document on contributing to the codebase?

from tianshou.

@DarkTechPirate How can I help?

from tianshou.

Yes, let's do like that. Looking forward to the PR.

from tianshou.

@DarkTechPirate I didn't see the PR. If you made some changes let's review them together in the PR even if you are unsure of the changes.
Pls add me as reviewer. Thank you!

from tianshou.

okay

from tianshou.