Code Monkey home page Code Monkey logo

Comments (5)

MatheusXavier avatar MatheusXavier commented on June 26, 2024 2

Hello Raman!

Thank you!


Have you posted this article to LinkedIn network?

No, I have not, only on medium.


Have you ever thought in terms of backward compatibility?

Thinking about backwards compatibility, I don't think it will be a problem because we don't need to apply everything in the article and almost everything in it works in dotnet 6.


If you have intention to contribute, I would ask you update all samples apps too... 🆗 ❔

Ok, I'll update the samples apps and the getting started doc.

Can you create a new branch for me so I can work on it?

from ocelot.

ggnaegi avatar ggnaegi commented on June 26, 2024 1

@MatheusXavier you should fork the repo, then create your own branch in the forked repo. When you are ready, you can from there create a PR.
image

from ocelot.

raman-m avatar raman-m commented on June 26, 2024

Hi Matheus!
Welcome to Ocelot world! 🐯

Nice article! Thanks you!
Have you posted this article to LinkedIn network?


Not that these points are serious problems, but I believe that the documentation could be updated.

Not serious! It could be, because we support .NET 6+ only since November'23.

Have you ever thought in terms of backward compatibility?
This old, legacy Program.Main startup approach is supported by .NET 6+ SDKs also...
But Yes, because .NET 6+ app can have implicit entry point aka Top-level statements so it makes sense to upgrade the docs and samples apps.

If you have intention to contribute, I would ask you update all samples apps too... 🆗 ❔

from ocelot.

raman-m avatar raman-m commented on June 26, 2024

@MatheusXavier As @ggnaegi said, you have to fork Ocelot repo and create feature branch in your forked repo.
More about our development process: Release Process

When you'll create a PR this feature ticket will be accepted.
But you can go to develop right now because you are assigned. 😉
Pay attention that Samples require to setup Docker Desktop and run Docker locally. All projects have Dockerfile.
Unfortunately, we have not added each Sample solution to Docker Compose project to have local Docker network when debugging and running.
Have you ever worked with Docker and Docker Compose?

Good luck having much inspiration!

from ocelot.

raman-m avatar raman-m commented on June 26, 2024

Three months have passed!..
@MatheusXavier, where are you?
You need to update your develop branch to be identical to head repo one! Now it has the diff. The diff must be zero, no changes at all.

Also I see the feature branch: 1912-update-docs-and-apps-samples
But it has no much changes, very initial development.
Why did you stop development on Jan 13?
What's your plan of delivery?

FYI

The samples folder was changed much in PR #2045 .
So, you have to rebase your feature branch! Or, create new branch from develop.

from ocelot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.