Altering subject in marshaler defaultNatsMsg about watermill-jetstream HOT 6 CLOSED

Thanks @seinshah seems we've all run into this. It was a carryover from the old STAN-based implementation and I don't see any reason we need it here. I am planning to do a little house keeping today, will cut a new tag and post here when it's available if you can test.

Happy to have a PR to reintroduce this behavior as a feature but I really don't see why we need it, it's easy enough to apply this logic at call sites to Publish or introduce a wrapped publisher.

from watermill-jetstream.

v0.0.6 should be good to go 🤞

https://github.com/ThreeDotsLabs/watermill-jetstream/tree/v0.0.6

from watermill-jetstream.

I think its fine for a 0.x release, I don't know of a lot of people using this at the moment and two of them have ended up blocked by this issue :) Since this will likely be deprecated for watermill-nats v2 eventually its probably what happens there that matters the most.

from watermill-jetstream.

Hi @seinshah,

I've already had the same problem and there's a PR #8 by @AlexCuse open to fix it!
There are some pieces in the code that rely on watermill messages having a UUID, which is optional.
I'm currently testing the new version and there may be some more modifications to fix that.

from watermill-jetstream.

BTW, there's also a PR open to move watermill-jetstream into watermill-nats: ThreeDotsLabs/watermill-nats#8 and after that this repo will eventually die.

from watermill-jetstream.

Thanks @AlexCuse. I will remove the custom marshaler with this change now. It seems like a breaking change to me for those who have used the default marshaler with the previous setup though. Am I wrong, or would that be ok?

from watermill-jetstream.