class names in modules about factory_bot HOT 6 CLOSED

I've run into this same problem that I documented in #28 before I saw this. Mine involves using :class => 'ActiveRecord::Base' notation, which I prefer to the slash. Your fix handles this notation as well. +1

from factory_bot.

Hey. That issue should be definitely fixed in master.
Here is my patch: http://github.com/mlomnicki/factory_girl/tree/namespaced_models_fix

It find easier to just use String.constantize then reinventing the wheel...

from factory_bot.

Awesome, thanks for fixing this.

As for String#constantize, I agree that it's much easier to do that than to pull the Object#const_get dance, but it should be noted that using constantize adds an implicit dependency on ActiveSupport. IMHO the difference between these two lines doesn't warrant the increased coupling.

foo.constantize
foo.split('::').inject(Object) { |o, str| o.const_get(str) }

Looking at the source though, it seems that AS is required in lib/factory_girl.rb already, so I'm not sure where factory_girl depends on it elsewhere.

Just trying to get into the rails3 decoupling spirit. :)

from factory_bot.

Good point with decoupling, I'll definitely fix it.

foo.split('::').inject(Object) { |o, str| o.const_get(str) }

Actually it doesn't handle 'admin/user' forms. In my opinion there should be constantize method available in factory_girl. We can use constantize if defined already or implement own otherwise.
Just like here http://github.com/svenfuchs/steam/blob/master/lib/core_ext/ruby/string/camelize.rb

What do you think?

from factory_bot.

Yeah that sounds good; just steal rails' implementation unless we already have it available. +1

from factory_bot.

thanks tdunn

from factory_bot.