Comments (7)
@boxofrox sorry that you're running into errors. I just tried it with my account using your steps, and I end up logged in.
Could this have been an intermittent issue with the GitHub API? Can you try again now?
from carnival.
I tried signing in again twice with github, but I still get the "Authorization Error". First tried with existing token I created for Carnival from earlier, then revoked that, and created a new token.
I checked the console log in case a more specific description of the problem was dumped there, but it's blank.
Not sure what else I can provide that would assist in reproducing this. If you need my public IP address to cross reference log files, I'm willing to provide it.
from carnival.
Searching for "auth" in today's logs, I found this entry:
10/Nov/2015:17:38:22 +0000 [Error] github: missing key name @(yesod-auth-1.4.4:Yesod.Auth ./Yesod/Auth.hs:314:15)
Maybe our GitHub sign in only works for users who have a name set on their GitHub profile? Can you try setting your name and logging in? If that's the issue, I think it's a bug on our end.
from carnival.
Looks like we do return an error for profiles without a name: https://github.com/thoughtbot/carnival/blob/master/Model/User.hs#L89
The GitHub OAuth2 Yesod adapter returns both name
(Maybe Text
) and login
(Text
) keys, so we could look for name
and fall back to login
from carnival.
Setting the name in my profile worked. Nice find.
from carnival.
Cool. Thanks for working through that with me. I'll try to get the login
fallback in on Friday.
from carnival.
My pleasure. I'll let you close the issue at your convenience.
from carnival.
Related Issues (20)
- Add copy to the homepage
- article_selector with id HOT 3
- Please add type="text/javascript" to the script tags HOT 3
- Make it possible to delete comments HOT 4
- Not working on my site HOT 4
- HTML is unescaped HOT 2
- Unsubscribe may be broken HOT 6
- Syntax error on docs page HOT 1
- Official tutorial for VPS HOT 1
- Consider replacing helper with middleware
- Experiment with Heroku Docker
- Set up Airbrake for 500 errors
- Comment feed contains bogus article URL due to omitting forward slashes
- Comments not working for bottom half of blog post HOT 1
- yesod devel fails on master
- New Comment button not appearing at certain screen sizes HOT 1
- Comments visually overflowing onto footer HOT 1
- Horizontal overflow for long strings
- Use free SSL option on Heroku?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carnival.