Comments (5)
One option (which might be a bit crazy) is to have breakpoint variables defined in Neat with !default
and also have them in Bitters's variables.scss
.
This would make it easier to use Bitters independent of Neat.
from bitters.
Please don´t make Neat a dependency, because i and others would be able to use a sytem like Susy for their grids, instead of neat.
from bitters.
I agree with @jmar, I wouldn't connect Neat with any typography module. I think that the main strength of the whole thoughtbot's "package" is modularity.
from bitters.
@kylefiedler What did you have in mind with the typography, exactly? I do love to enlarge the global font-size via media-queries on the body
tag:
body {
font-size: $base-font-size;
@include media($small-screen-up) {
font-size: $base-font-size * 1.0625;
}
@include media($medium-screen-up) {
font-size: $base-font-size * 1.1875;
}
@include media($large-screen-up) {
font-size: $base-font-size * 1.375;
}
}
However, I also worry about making a Neat dependency and forcing people to include it when they might want to use another grid framework.
If you have some specific ideas (or maybe mine above), they could be added to Refills’ type system components.
from bitters.
I could see having some basic media query variables added to bitters to let us do some more advanced typography, etc. This could be done right with using the same variable names some clever use of !default
. I would definitely agree that one of the greatest strengths of the bourbon system is its modularity and it would be dangerous to remove that.
from bitters.
Related Issues (20)
- Bitters v2.0.0 is not published to RubyGems HOT 1
- Bourbon’s `modular-scale` function is still used
- Bourbon is still imported in the contributing site
- Button's have inaccessible text color
- Use font weight variables?
- Remove duplication of normalize.css styles
- Add support for ensuring the HTML hidden attribute hides content
- Swap the term “base” for “elements”
- Add normalize.css to contributing site
- In Safari, search inputs are a different height
- Replace gulp with Parcel
- Buttons, links styled as classes instead of elements HOT 1
- Add `height: auto` to `img`
- Deploy preview site to Netlify for deploy previews HOT 1
- Releasing command not working
- Improve testing
- Document browser support
- Add more post-publish steps to releasing documentation
- Netlify site not building HOT 1
- CI fails due to bundler version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitters.