Comments (10)
The intended use is with a reset and the reset (we use normalize) should take care of setting those HTML 5 elements. Bitters is meant to act as a starting guide for your project. With the reset you should put it in your project and not really edit it, Bitters you should edit to the projects needs ie change the variables to suite your sites style.
Its a little different than most projects that way. Hopefully the edits I've made to the documentation make this more clear. If not let me know.
from bitters.
@kylefiedler gotcha. Buuut... if it specifies basic style to p and blockquote, why not article?
from bitters.
@jjb The styes for <p >
and <blockquote>
would be on top of a reset or browser defaults to make them consistent with the vertical rhythm that the rest of Bitters has. Other than displaying article block, which should be in a reset, what other styles do you want for it?
from bitters.
@kylefiedler you made blockquotes grey and indented, which seems to coincide with the purpose of a blockquote. so an article is presumably the main consumable content on a page, which might warrant a slightly bigger font, and a limit on maximum width.
from bitters.
@jjb I think your wording is best; it "might" need those styles. I'd wonder why you wouldn't increase the font-size or have a container for your entire site, maybe use Neat :).
I'm more open to the idea of removing the gray border and indentation on <blockquote>
and harping on me for making too many assumptions about that. I believe that its more expected to see those styles on a blockquote than the styles you mentioned above on an article, I'm willing to be wrong though.
from bitters.
if you would remove the blockquote style then i don't know what the purpose of the project is :) maybe that should be established better.
from bitters.
maybe you could elaborate on "consistent with the vertical rhythm that the rest of Bitters has" -- what does that mean?
from bitters.
Bitters is meant to help designers get projects started faster. It adds enough predefined structure and style to get started quickly but not enough to dictate style moving forward.
The spacing around type is based on $base-line-height so as to keep a semi-baseline grid. All sizes are scaled up or down by a factor of .25.
Do those help in anyway with your questions?
from bitters.
I guess I was thinking it would be cool to have minimal meaningful style for each type of element. The style that bitters has so far does go along with this, so I thought some minimal style for other elements might be appropriate.
I guess the larger issue is that the goal of the project is still a bit murky. Those two sentences from the readme don't get us very far. To be clear, I'm not advocating for it to have any particular purpose! Just discussing things...
Perhaps the readme should answer this question: If I've installed bourbon, neat, and normalize, what problem do I have that bitters is now solving for me? Candidates:
- there is CSS that every project these days that we don't want to retype every time. (problem with this answer: the readme states that bitters should be modified after installation)
- thoughtbot has an opinion about fundamentals of style
- thoughtbot has an opinion about how to organize CSS files and their content
- something else...
from bitters.
I guess I was thinking it would be cool to have minimal meaningful style for each type of element.
I think the best way for us to have that discussion on a case by case basis. I believe some elements don't need minimal style or by adding style you are assuming too much how the element is going to be used. Please make PR with style that you think is missing. I'd be happy to have more in depth discussions on specific examples. If you feel strongly about the articles example I think that would be a good one to start with.
I guess the larger issue is that the goal of the project is still a bit murky.
I hope this is just due to the projects infancy and me not taking enough time on the documentation. Hopefully I can make this more clear as I spend more time on the project.
I think you bring up some great points and Bitters is meant to solve some of those and not some of the others. In general this is meant to update and replace a lot of the styles that were found in Flutie. Its meant so that the start of a project doesn't look terrible but doesn't add nearly as much style as something like Bootstrap. It also speaks to the way that we organize our sass. Everything central to the project should be added to the base folder. A dated form of that thinking can be found here: http://robots.thoughtbot.com/post/25098505945/style-sheet-swag-architecting-your-applications-styles
Let me know if you have any other questions.
from bitters.
Related Issues (20)
- Bitters v2.0.0 is not published to RubyGems HOT 1
- Bourbon’s `modular-scale` function is still used
- Bourbon is still imported in the contributing site
- Button's have inaccessible text color
- Use font weight variables?
- Remove duplication of normalize.css styles
- Add support for ensuring the HTML hidden attribute hides content
- Swap the term “base” for “elements”
- Add normalize.css to contributing site
- In Safari, search inputs are a different height
- Replace gulp with Parcel
- Buttons, links styled as classes instead of elements HOT 1
- Add `height: auto` to `img`
- Deploy preview site to Netlify for deploy previews HOT 1
- Releasing command not working
- Improve testing
- Document browser support
- Add more post-publish steps to releasing documentation
- Netlify site not building HOT 1
- CI fails due to bundler version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitters.