Relative gemfiles location breaks cucumber tests with aruba about appraisal HOT 5 CLOSED

I tried changing the gemfile_root method of Appraisal::Appraisal to be:

::File.join(Dir.pwd, "gemfiles")

That passes the test suite and works for the first appraisal (trying it out on Clearance). However, the second appraisal it tries to run, it had a duplicated path:

/Users/lawless/dev/clearance/Users/lawless/dev/clearance/gemfiles/3.0.9.gemfile

So there's something about the process going on that I don't quite understand yet.

from appraisal.

Hmm weird behavior.

I've tried on my end with

def gemfile_root
  ::File.join(Dir.pwd, "gemfiles")
end

With rspec-subject-extensions it works like a charm with 2 appraisals (under MRI 1.8.7 and MRI 1.9.2)
However I've tried with Clearance as well and it fails at the first appraisal in my case.

I'll keep investigating to see what's going on.

from appraisal.

Ok, here's the catch. https://github.com/thoughtbot/clearance/blob/master/features/support/appraisal.rb#L4

If using ::File.join(Dir.pwd, "gemfiles") directly in appraisal, this is no longer required. As long as it can break compatibility, I think it's a nice update to make Appraisal usage even easier.

Tested with Clearance and works nicely.

from appraisal.

Good call. Made the changes to appraisal and clearance.

549f3fa
thoughtbot/clearance@ef95328

from appraisal.

Sweet, thanks a lot for your help and work. Looking forward for the version bump ;-)

from appraisal.