Comments (1)
I have been looking into the code base to track down this issue, and found that it was actually a race condition.
It turns out that if there is another rule that can block the dependent rule until the post build completes, then everything works as expected. Otherwise, the same issue as mentioned occurs.
Here is an example build script that will succeed:
def post_func(ruleName, cmdOutput):
fileRule = genrule(name="postFile", cmd = "sleep 10; touch postFile.txt", out="postFile.txt")
add_dep(ruleName, fileRule, True)
genrule(name="postRule", cmd="", post_build=post_func)
genrule(name="waitRule", cmd="sleep 11; touch waitFile.txt", out="waitFile.txt")
genrule(name="postRuleConsumer", cmd="", deps=[":postRule", ":waitRule"])
Note the sleep 10
in the file rule and sleep 11
in the wait rule. As long as the "postFile" rule in this example completes before the "waitRule" everything works.
from please.
Related Issues (20)
- Re-enable //test/proto_plugin:proto_rules_test
- Bug in codelab - wrong port
- Crash on tab completion
- Target not found from subrepo
- Support instantiation_stack when querying HOT 1
- Panic / segfault when using query command with --arch option that doesn't match the platform
- Intermediate build results (phase A and B) HOT 6
- Tools not found with --shell & remote execution
- .plzconfig key with empty value HOT 4
- review Go analysis.Pass.Module proposal HOT 1
- Third party dependencies fail to add with please_go HOT 4
- Adding please to a large repo - how to migrate to please and best practices for upkeep HOT 3
- SLSA and Provenance attestation data for builds HOT 3
- pkl + plz: multi-directory genrule outs HOT 2
- plz clean doesn't remove LinkGeneratedSources'ed links HOT 3
- plz query codelab still references go_get()
- plz init still suggests getting auxiliary rules from the Pleasings repo
- Support for tab escape charcter missing. HOT 1
- List concatenation bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from please.