Code Monkey home page Code Monkey logo

Comments (4)

thombashi avatar thombashi commented on June 19, 2024 2

pathvalidate v3.2.0 can do the following:

from pathvalidate import sanitize_filename, ValidationError

def add_trailing_underscore(e: ValidationError) -> str:
    if e.reusable_name:
        return e.reserved_name

    return f"{e.reserved_name}_"

sanitize_filename(".", reserved_name_handler=add_trailing_underscore, additional_reserved_names=["."])
'._'

from pathvalidate.

blerrgh avatar blerrgh commented on June 19, 2024

Was this ever resolved? I have the same issue in 2.5.2

It would be great if sanitize_filename("..") (or maybe sanitize_filename("..", check_reserved=True)) returned "_"

from pathvalidate.

thombashi avatar thombashi commented on June 19, 2024

I have considered this previously and concluded that it is difficult to apply replacements unconditionally.
Unlike other reserved words, . and .. can be assumed to be recognized as reserved keywords and used as reserved names in most cases, so I think it is inappropriate to treat them in the same way as other reserved words.
In many cases, users would expect to preserve . and .. as they are, and there is a possibility that the valid file paths are broken if they are replaced.

In the future, another solution may be to add an interface that specifies a callback function to process reserved names.
By customizing this callback function, changing the behavior as you wish will be possible.

from pathvalidate.

blerrgh avatar blerrgh commented on June 19, 2024

In many cases, users would expect to preserve . and .. as they are, and there is a possibility that the valid file paths are broken if they are replaced.

I agree that they probably shouldn't be replaced in sanitize_filepath since both . and .. are valid in relative paths. But personally I'm not sure I would expect them to ever be valid via sanitize_filename since you cannot name a file . or ...

I suppose if people are using sanitize_filename to check individual path components then they might want to preserve periods.

from pathvalidate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.