SAFRSRestRelationshipAPI returns all objects in db of the related type about safrs HOT 5 CLOSED

well, this is a pretty unfortunate screwup.
I'll have to think how to fix this: problem is that the relationship can be either an instance of

• AppenderBaseQuery (in the case the relation has been configured with lazy="dynamic". This would be ok
• InstrumentedList, in which case I can't perform any more queries on it

anyway, following may fix it temporarily

            data = [item for item in relation if isinstance(item, SAFRSBase)]
            meta = {"direction": "TOMANY"}
            instances = jsonapi_filter(self.child_class)
            instances = jsonapi_sort(instances, self.child_class)
            #links, data, count = paginate(instances, self.child_class)
            links = {}
            count = len(data)

but there are obv other issues: no filtering and sorting and the lack of pagination means it will work badly for large relations

I'll have to investigate this a bit further

from safrs.

If it's an InstrumentedList perhaps one could construct a base query manually: self.child_class.query.filter(self.child_class.id.in_([item.id for item in relation])) or something (but with dynamic primary key name I guess).

Or maybe the lazyness can be overridden temporarily in this case..? Not sure how though.

from safrs.

I've commited a fix.
I should make the sort/filter/paginate more consistent eventually, but I think this will work for now.

from safrs.

Too bad filtering was omitted, but at least it works now 👍
Btw, opting for other loading techniques than dynamic at declaration time is basically a choice made not to enable filtering or sorting, isn't it? Considering that, it might be easier to allow these operations only when the relationship is of the query type.

from safrs.

I'll implement filtering and sorting too, but these have to reimplemented on list objects instead of query objects :/

from safrs.