Additional German translations about flexboxfroggy HOT 2 CLOSED

No problem, I will update the German translations in a second.

However, I would strongly suggest to fully separate any (to-be-translated) strings from the rest of the app, and thus have only one index.html that reads the user's language and then uses the according strings (with a fallback to English for any missing translation). Otherwise, keeping the translations up-ot-date is a very tedious task. For instance, adding a new language would require updating also all the other index.html files. Having a separate file (e.g., strings.js, or even strings.json) and then reading the according string is, in my opinion, the way to go.

var strings = {
    game: {
        level1: {
            en: '...',
            de: '...',
        }
    },
    messages: {
        warningReset: {
            en: '...',
            de: '...',
        }
    }
};

var getString = function( lang, id ) {
    var properties = id.split( '.' ),
        property,
        value = strings;

    while( properties.length ) {
        property = properties.shift();

        if ( ! value.property ) {
            return 'return empty string or something else here';
        }

        value = value.property;
    }

    if ( value.lang ) {
        return value.lang;
    } else if( value.en ) {
        return value.en;
    } else {
        return 'same error string from above or so...';
    }
};

Note this is just a quick write-up. Please don't take it as-is. :)

from flexboxfroggy.

Thanks @tfrommen, the way languages are handled is definitely due for a refactor. Your approach looks good to me, though I might prefer to use a query string than automatically detect the user language. I'll merge your changes for now and hopefully get to that soon.

from flexboxfroggy.