Connection leak on execute (Hikari) about rxkotlin-jdbc HOT 7 OPEN

In follow up I'd like to add I've discovered another situation in which a connection is leaked, namely on db.execute and db.insert when the query results in a SQLException. I will try to upload a MVC example soon.

from rxkotlin-jdbc.

Okay, I'm on vacation but I'll look at it when I get back in a few days. If you can please confirm it's not an issue with Hikari or the MySQL driver and that it is RxKotlin-JDBC that is the source of the issue

from rxkotlin-jdbc.

Hmm... yes there is something that doesn't look right here when comparing the implementation of insert() and execute(). The insert() relies on the iterator of toObservable() to close the connection whereas the execute() does nothing with the autoClose argument. I'll take care of this.

https://github.com/thomasnield/rxkotlin-jdbc/blob/master/src/main/kotlin/org/nield/rxkotlinjdbc/UpdateOperation.kt#L37-L39

https://github.com/thomasnield/rxkotlin-jdbc/blob/master/src/main/kotlin/org/nield/rxkotlinjdbc/InsertOperation.kt#L53-L55

from rxkotlin-jdbc.

@Warkst Alright, I implemented a fix. Can you test a build? You can use JitPack to bring this in as a dependency:
https://jitpack.io/#thomasnield/rxkotlin-jdbc/596332118a

from rxkotlin-jdbc.

Thanks @thomasnield for looking into this. I'm still experiencing connection leaks when something like

    db.execute("some pre-built insert statement").toSingle().blockingGet()

results in an exception.

from rxkotlin-jdbc.

Hi!
Has this issue been resolved yet?

from rxkotlin-jdbc.

Any updates on this??

from rxkotlin-jdbc.