Should queued task take care about closing the page? about puppeteer-cluster HOT 4 CLOSED

The page will be closed as soon as your task function is executed.

But you can use a Promise to wait until you are done. Then you call the resolve function to close the page.

await cluster.task(async ({ data, page }) => {
    await new Promise((resolve) => {
        // do some asynchronous stuff
        // maybe call an async function like setTimeout?
        setTimeout(() => {
            // do more stuff...
            // When we are done we call resolve() to resolve the promise
            resolve(); // this will finish the task function and the page will be closed
        }, 3000);
    });
});

Be careful with asynchronous functions though. Asynchronously thrown errors cannot be caught by the library. So don't forget try-catch blocks where necessary.

from puppeteer-cluster.

It is done automatically. As soon as your task function finishes (or a timeout happens) the opened resources will be closed. You do not need to worry about that.

If you want to see it in action, you can run puppeteer locally and disable headless mode.

from puppeteer-cluster.

Thanks for the response, @thomasdondorf. Another question came to my mind: is the page.close() done by puppeteer-cluster? Asking because had a lot of Protocol error (Page.navigate): Target closed., stack=Error: Protocol error (Page.navigate): Target closed. during the ~45 mins of run of a process.

from puppeteer-cluster.

Another question: can I control page termination myself without relying on automation? It seems for now it getting closed (lost context) before all operations are completed.

from puppeteer-cluster.