Oh-no! Awesome-lint errors! 😱 about awesome-web-monetization HOT 7 CLOSED

Hey, you got it to work! Well done! 👍 And the final warning "Git repository must be at least 30 days old" should also be resolved now 🎉

from awesome-web-monetization.

Of course @Potherca ! He merged yesterday 😄☕

from awesome-web-monetization.

Oh thanks for that ! I jus edited topics. One more left, waiting for 30 days :D

It is possible to add a awesome-lint as package.json and/or github action. If desirable, I can help set this up 👍

What's that for on this repository?

from awesome-web-monetization.

Currently, there isn't a Github Action (or external CI) that runs the awesome-linter against commits or merge-requests. Adding a Github Action for this will make an ✅ or ❌ show up for commits and MRs, so you can see if they pass the linter (or not)

I've created two example here:

• potherca-contrib#1
• potherca-contrib#2

The first uses NPM to run the awesome linter. The benefit of this is that anyone who wants add something can just run npm i && npm test locally, and the linter will run. The downside is that this means adding a package.json, package-lock.json, and .gitignore file, besides the github actions file.

The second example doesn't add any of these files but instead uses a Github Action that provides awesome-lint. If you expect most people to edit the readme.md on Github anyway, it saves adding superfluous files to the repo.

You can see the builds here:

• https://github.com/potherca-contrib/awesome-web-monetization/runs/792812977?check_suite_focus=true
• https://github.com/potherca-contrib/awesome-web-monetization/runs/792812585?check_suite_focus=true

(Please note that the errors you see there are of my repo, not yours...)

If you would like to use either one in this repo, just let me know which one... I can easily open an MR for it here 😁 .

from awesome-web-monetization.

Oh so cool ! Adding Awesome-lint NPM could be good for so as not to waste too much time checking for errors every time. 🐙

You can create a new PR for adding this Action to this repository and I accept this new feature 👏

from awesome-web-monetization.

Okay thanks you for helped me @Potherca ! I forget to add package.json for working correctly.. ^^"

from awesome-web-monetization.

Shouldn't this be closed, as the linter passes and sindresorhus/awesome#1812 has been merged?

from awesome-web-monetization.