Question about development about octoprint-pushover HOT 4 CLOSED

Hello !!

Please do, I would love too see your new features and have someone else develop at this plugin. It is a good solution to limit those new features. Below is a picture of the recent usage of this API key. The average each month is 10,000 notifications, they where so kindly that they upgraded it from 10,000 to 12,500.

I will see your pull request.

from octoprint-pushover.

Alright, I've got a couple questions about your code / code style.

1. Is it acceptable to rearrange a couple of your methods to for example put the events in expected chronological order?
2. To add the functionality of regular (hour by default) progress updates, is it good form to add an 'API' command to on_api_command and the related locations, then call that from the event / timer? If not, where would you like me to place that functionality?

Thanks!

from octoprint-pushover.

Hi,

1. Yeah it is acceptable to rearrange and move stuff. I don't have a specific standard for this project.

2. Why wouldn't you place it there ? Why not ?

from octoprint-pushover.

Thanks!

Anyways, I've made some progress on this, but other projects have come up first, so it may be a while.

I'll just close this issue for now, since the original question I asked has been answered. :)

from octoprint-pushover.