Supporting SDWebImage about idmphotobrowser HOT 19 OPEN

Is there any particular reason you need or want to use SDWebImage to manage image downloads? Since AFNetworking works nice.

from idmphotobrowser.

It's simply a choice of your image caching engine. If you're already using SDWebImage elsewhere, it makes sense to keep using it (rather than having two separate caches).

from idmphotobrowser.

In general, I think a positive architectural change would be to factor out all of the cocoa pods dependencies of IDMPhotoBrowser via sub specs (as mentioned above), or via delegate patterns. This is particularly important for UI elements (DACircularProgressView), for app-specific UI consistency.

from idmphotobrowser.

+1

from idmphotobrowser.

+1

from idmphotobrowser.

+1 for SDWebImage

from idmphotobrowser.

+1

from idmphotobrowser.

+1

from idmphotobrowser.

+infinite

from idmphotobrowser.

For me the biggest advantage is that SDWebImage supports disk caching whereas AFNetworking only supports memory caching. Concretely, that means that big images don't get cached at all and cache doesn't survive app restart.

from idmphotobrowser.

maybe extract the cache interface, set default provider as AFNetworking but also allow other providers.

from idmphotobrowser.

+1

from idmphotobrowser.

I am interested. Thank you. How do you alter the podFile to implement this branch?

from idmphotobrowser.

@robmontesinos here's how you tell cocoapods to go fetch a fork instead of the original project:

pod 'IDMPhotoBrowser', :git => 'https://github.com/[username]/IDMPhotoBrowser.git'

from idmphotobrowser.

Thank you @sprint84!! I had different options to go from googling. I appreciate your super quick response!!

from idmphotobrowser.

+1 for SDWebImage

from idmphotobrowser.

+1

from idmphotobrowser.

+1

from idmphotobrowser.

+1

from idmphotobrowser.