Comments (5)
Thanks for the report! Hopefully fixed it:
697922a
from aha.
Thank you very much for the quick fix !
I confirm it works as expected now (I only tested text color, not background).
from aha.
In fact I thought, that the background color 0 in contrast to the foreground color 0 should be black instead of darkgray.
So I fixed this only for the foreground color.
Do I need to fix the background color, too?
I took a look at this page only now:
http://en.wikipedia.org/wiki/ANSI_escape_code
Before I did just have a look, how my terminal emulator handles the color.
This source says, \033[1 is increased intensity (which would make darkgray out of black) or bold.
So if I use bold already, should the foreground colour then be black anyway?
Or if I use both (bold and brighter color), shouldn't I "bright up" the other colours, too?
Would it be furthermore not more correct to use darkgray only for bright/bold letters? I use it now for both, because my terminal emulator does the same.
Maybe I should just not try to be too correct... Otherwise I could just rewrite the whole application. :\
On Sat, 24 Jan 2015 06:17:23 -0800
Vincent Pelletier [email protected] wrote:
Thank you very much for the quick fix !
I confirm it works as expected now (I only tested text color, not background).
Reply to this email directly or view it on GitHub:
#9 (comment)
from aha.
True, it can be interpreted as bold too.
I guess there is just no correct implementation, but at best consistent implementations.
I probably should just use another colour in my program, for the same reason.
FYI, here are a few files generated via aha:
https://github.com/vpelletier/ITI1480A-linux/tree/master/examples
and especially hci_endianness_bug.usb_vvv.html , which uses darkgray in several places: hexdump offsets and less interesting capture events.
from aha.
Looks quite good. Maybe the most important thing is, that the colours are readable, quite close to the terminal output and of course readable.
So I will just keep it this new way, I thing it is a good compromise.
Thanks for your examples. Always nice to see, how other people use my work. :D
On Sat, 24 Jan 2015 10:10:20 -0800
Vincent Pelletier [email protected] wrote:
True, it can be interpreted as bold too.
I guess there is just no correct implementation, but at best consistent implementations.
I probably should just use another colour in my program, for the same reason.FYI, here are a few files generated via aha:
https://github.com/vpelletier/ITI1480A-linux/tree/master/examples
and especially hci_endianness_bug.usb_vvv.html , which uses darkgray in several places: hexdump offsets and less interesting capture events.
Reply to this email directly or view it on GitHub:
#9 (comment)
from aha.
Related Issues (20)
- need help explaining htop fix
- Using the --no-header option strips all HTML tags, not just <head> section
- Support new(ish) hyperlink standard
- Italics support HOT 6
- aha seems to escape it's own generated html HOT 3
- Feature request: Process CR characters to match final terminal output HOT 7
- font-size option HOT 1
- Using filter: instead of 2 sets of colors is broken (v0.5.1) HOT 1
- Add tests to the repo HOT 4
- Choose a different font for the output HOT 1
- `make install` does not work on macOS HOT 3
- contribution: convert aha's html output to github-compatible html
- Trying to get in touch regarding a security issue
- Buffering, and blocking HOT 1
- SI/SO doesn't seem to work
- --line-fix leads to double-spaced output
- Feature request: Ignore xterm alternate screen
- aha: Buffer overflow in main function at aha.c:973 in aha 0.5.1 allows remote attackers to cause a denial of service (crash) via a crafted input document.
- Problem with PHP
- New release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aha.