thexa4 / source-pbr Goto Github PK

When generating a cubemap, it doesn't blur with the roughness.is there a way to fix this?

game always crash when load a map

I've had this bug for a while, completely unsure as to what it could be.

Whenever a projectedtexture is cast from a relatively far distance onto a model, it seems to render the model at max brightness no matter what the actual lamp's brightness value is.

Examples:

Mesh over brightening:

The lamp's brightness values:

update: OK, it seems to be an issue regarding the FarZ of the projectedtexture. By the looks of it, the shader doesn't account for possible loss in brightness when the lamp is cast from far away with a high FarZ value, instead what I think it does is take the default FarZ value of 1024 and keeps the brightness from that value meaning it doesn't update with the changes to the FarZ value.

Which explains as to why projectedtextures look absolutely fine from up close (player flashlights), but seem to mess up once the projectedtexture is casted from far away.

$basetexturetransform is nonfunctional, it doesn't seem to do anything to the basetexture.

https://github.com/thexa4/source-pbr/blob/feature/pbr-base/mp/src/materialsystem/stdshaders/pbr_dx9.cpp#L401

Where does this iEnvMapLOD comes from

hi there!

the $useparallax to 1, is not working.

neither on models or brushes, do you know why? and how to get this fixed.

any help would be so much appreciated, because there is no Parallax is any open source, only outdated ones.
i really need parallax to work, that would be a dream.

     "$useparallax"	"1"
"$parallaxdepth"	"600" (to see if there is any different changes)
"$parallaxcenter"	"1"

thank you for making this!!!
and thank you for reading.

It crashes when you do mat_reloadallmaterials

The reason is that Source 2013SP does not support registers higher than c31 while this shader uses hardcoded c40.
Changing it to generally free c27 fixes everything.

when trying to build the game on Windows 10, I get this error in the build:

'3>d:\game projects\source sdk 2013 pbr\mp\src\materialsystem\stdshaders\pbr_dx9.cpp(251): error C2039: 'SetUSEENVAMBIENT' : is not a member of 'pbr_ps30_Static_Index'
3> d:\game projects\source sdk 2013 pbr\mp\src\materialsystem\stdshaders\fxctmp9\pbr_ps30.inc(3) : see declaration of 'pbr_ps30_Static_Index'
3>d:\game projects\source sdk 2013 pbr\mp\src\materialsystem\stdshaders\pbr_dx9.cpp(252): error C2039: 'SetEMISSIVE' : is not a member of 'pbr_ps30_Static_Index'
3> d:\game projects\source sdk 2013 pbr\mp\src\materialsystem\stdshaders\fxctmp9\pbr_ps30.inc(3) : see declaration of 'pbr_ps30_Static_Index'
3>d:\game projects\source sdk 2013 pbr\mp\src\materialsystem\stdshaders\pbr_dx9.cpp(253): error C2065: 'psh_forgot_to_set_static_CONVERT_TO_SRGB' : undeclared identifier'

I have successfully built the official SDK before, so I know that my config is not an issue.

As described in the title, the prop_physics entities lose their color data when they are not moving.

On the left is model with $CollisionModel added, and on the right is a model without collision:

(tested on two different maps with correct lighting and cubemaps)

pbr_ps20b 3 ERROR(S):
error X4018: Shader uses texture addressing operations in a dependency chain that is too complex for the target shader model (ps_2_b) to handle.
Reported 3360 time(s), example command:
fxc /DCENTROIDMASK=0 /DSHADERCOMBO=3bff /DSHADER_MODEL_PS_2_B=1 /Tps_2_b /Emain /DWRITEWATERFOGTODESTALPHA=1 /DPIXELFOGTYPE=1 /DNUM_LIGHTS=4 /DWRITE_DEPTH_TO_DESTALPHA=1 /DFLASHLIGHTSHADOWS=1 /DFLASHLIGHT=1 /DFLASHLIGHTDEPTHFILTERMODE=2 /DLIGHTMAPPED=1 /DUSEENVAMBIENT=1 /DEMISSIVE=1 /DSPECULAR=1 /DPARALLAXOCCLUSION=1 pbr_ps30.fxc
pbr_common_ps2_3_x.h(61,19-25): error X4532: cannot map expression to pixel shader instruction set
Reported 240 time(s), example command:
fxc /DCENTROIDMASK=0 /DSHADERCOMBO=1c43 /DSHADER_MODEL_PS_2_B=1 /Tps_2_b /Emain /DWRITEWATERFOGTODESTALPHA=1 /DPIXELFOGTYPE=1 /DNUM_LIGHTS=3 /DWRITE_DEPTH_TO_DESTALPHA=1 /DFLASHLIGHTSHADOWS=0 /DFLASHLIGHT=0 /DFLASHLIGHTDEPTHFILTERMODE=0 /DLIGHTMAPPED=1 /DUSEENVAMBIENT=1 /DEMISSIVE=1 /DSPECULAR=1 /DPARALLAXOCCLUSION=0 pbr_ps30.fxc
pbr_common_ps2_3_x.h(59,18-23): error X4532: cannot map expression to pixel shader instruction set
Reported 3120 time(s), example command:
fxc /DCENTROIDMASK=0 /DSHADERCOMBO=1dff /DSHADER_MODEL_PS_2_B=1 /Tps_2_b /Emain /DWRITEWATERFOGTODESTALPHA=1 /DPIXELFOGTYPE=1 /DNUM_LIGHTS=4 /DWRITE_DEPTH_TO_DESTALPHA=1 /DFLASHLIGHTSHADOWS=1 /DFLASHLIGHT=1 /DFLASHLIGHTDEPTHFILTERMODE=2 /DLIGHTMAPPED=1 /DUSEENVAMBIENT=1 /DEMISSIVE=1 /DSPECULAR=1 /DPARALLAXOCCLUSION=0 pbr_ps30.fxc
FAILED: pbr_ps20b
4 minutes, 4 seconds elapsed
07:31 PM

Press any key to continue . . .

get this on source sdk 2013 multiplayer shader compile.

Using $translucent or $alphatest in a PBR material makes it invisible.

After adding $translucent "1" or $alphatest "1":

And it's not a problem with the texture itself, here's the same material but with VertexLitGeneric shader and $translucent "1":

Hey. I tried to transfer your PBR to my project with a few corrections. Everything was successfully compiled. The game complains of an error and does not show the texture. Materials for PBR prepared.

Houston we have a problem. Bumpmap does not want to work on the new shader. What the problem is is not clear.
Checked both $normaltexture and $bumpmap. Nothing works. Models remain smooth.

Hi,

The shader does really well except for when using the flashlight on a model. At certain angles, the lighting on the model seems to change to only be the flashlight or something? It's believed that perhaps the lighting origin is changing for the model. Not sure what's up.

Here's a gfycat of it happening:
https://gfycat.com/adorablepassionatechipmunk

It doesn't have some methods like:
" SetModulationPixelShaderDynamicState_LinearColorSpace"
"pShaderAPI->SetPixelShaderStateAmbientLightCube"
...

If I add $model 1 in the VMTs, overbright disappers, but the reflection is not working as expected


Reflection will changes while player is moving

From what I see the speculars from a projected texture draw correctly, but the diffuse is all broken, it's drawn at the lowest point of the parallax depth, with no parallax effect applied.
Image has Lightmappedgeneric on the right, PBR on the left with a projected texture pointing at the ground.

Lightmaps doesn't work when I bake something using the PBR

When shining a light (flashlight typically), on any model that uses $alphatest; causes the model to not take light properly-even without the flashlight. Below are two images; one with the alpha on, and the other off.

You can see how the light affects the one with it off, as a model typically should look if a light is shined on it. Puzzled as to why this is the case, below are the VMT parameters for the Body, cape isn't any different.

"PBR"
{
	"$basetexture" 			"models/souls/ds3/c1280/var1_body_a"
	"$bumpmap"       		"models/souls/ds3/c1280/var1_body_n"
	"$mraotexture"   		"models/souls/ds3/c1280/var1_body_mrao"
	"$speculartexture"  	        "models/souls/ds3/c1280/var1_body_r"
	"$envmap"        		"env_cubemap"

	"$surfaceprop"   		"metal"
	"$model"         		"1"
	"$alphatest"			"1"
	"$alphatestreference"	        "0.6"
}

Creating a large pack with this shader would be beneficial for Garry's Mod, especially if it garners a lot of attention. Issues with lighting regarding the $alphatest, are problematic; personally, I'm not sure if there's ways around this that I'm not aware of. When the pack is uploaded, I'll provide a link here should it gather a large group of people; maybe then, Rubat might actually make it required--if he sees a real need for it.

The pbr shader only seems to work right on prop_dynamic, prop_static will only give off a convincing pbr effect when an env_projectedtexture is used.

Flashlight off ^^

Flashlight on ^^